public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
* [PATCH] conf: Report usage for --no-netns-quit
@ 2022-10-07  7:16 Stefano Brivio
  2022-10-09  5:41 ` David Gibson
  0 siblings, 1 reply; 2+ messages in thread
From: Stefano Brivio @ 2022-10-07  7:16 UTC (permalink / raw)
  To: passt-dev

[-- Attachment #1: Type: text/plain, Size: 805 bytes --]

Fixes: 745a9ba4284c ("pasta: By default, quit if filesystem-bound net namespace goes away")
Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>
---
 conf.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/conf.c b/conf.c
index 5a7f9b9..4ec1590 100644
--- a/conf.c
+++ b/conf.c
@@ -787,6 +787,8 @@ pasta_opts:
 	info(   "  --netns PATH|NAME	Target network namespace to join");
 	info(   "  --netns-only		Don't join existing user namespace");
 	info(   "    implied if PATH or NAME are given without --userns");
+	info(   "  --no-netns-quit	Don't quit if filesystem-bound target");
+	info(   "  			network namespace is deleted");
 	info(   "  --config-net		Configure tap interface in namespace");
 	info(   "  --ns-mac-addr ADDR	Set MAC address on tap interface");
 
-- 
@@ -787,6 +787,8 @@ pasta_opts:
 	info(   "  --netns PATH|NAME	Target network namespace to join");
 	info(   "  --netns-only		Don't join existing user namespace");
 	info(   "    implied if PATH or NAME are given without --userns");
+	info(   "  --no-netns-quit	Don't quit if filesystem-bound target");
+	info(   "  			network namespace is deleted");
 	info(   "  --config-net		Configure tap interface in namespace");
 	info(   "  --ns-mac-addr ADDR	Set MAC address on tap interface");
 
-- 
2.35.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] conf: Report usage for --no-netns-quit
  2022-10-07  7:16 [PATCH] conf: Report usage for --no-netns-quit Stefano Brivio
@ 2022-10-09  5:41 ` David Gibson
  0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2022-10-09  5:41 UTC (permalink / raw)
  To: Stefano Brivio; +Cc: passt-dev

[-- Attachment #1: Type: text/plain, Size: 1148 bytes --]

On Fri, Oct 07, 2022 at 09:16:41AM +0200, Stefano Brivio wrote:
> Fixes: 745a9ba4284c ("pasta: By default, quit if filesystem-bound net namespace goes away")
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  conf.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/conf.c b/conf.c
> index 5a7f9b9..4ec1590 100644
> --- a/conf.c
> +++ b/conf.c
> @@ -787,6 +787,8 @@ pasta_opts:
>  	info(   "  --netns PATH|NAME	Target network namespace to join");
>  	info(   "  --netns-only		Don't join existing user namespace");
>  	info(   "    implied if PATH or NAME are given without --userns");
> +	info(   "  --no-netns-quit	Don't quit if filesystem-bound target");
> +	info(   "  			network namespace is deleted");
>  	info(   "  --config-net		Configure tap interface in namespace");
>  	info(   "  --ns-mac-addr ADDR	Set MAC address on tap interface");
>  

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-10-09  5:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-07  7:16 [PATCH] conf: Report usage for --no-netns-quit Stefano Brivio
2022-10-09  5:41 ` David Gibson

Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).