Re: [PATCH 1/3] tcp, tcp_splice: Adjust comments to current meaning of inbound and outbound

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 2005 bytes --]

On Tue, Oct 11, 2022 at 01:33:48AM +0200, Stefano Brivio wrote:
> For tcp_sock_init_ns(), "inbound" connections used to be the ones
> being established toward any listening socket we create, as opposed
> to sockets we connect().
> 
> Similarly, tcp_splice_new() used to handle "inbound" connections in
> the sense that they originated from listening sockets, and they would
> in turn cause a connect() on an "outbound" socket.
> 
> Since commit 1128fa03fe73 ("Improve types and names for port
> forwarding configuration"), though, inbound connections are more
> broadly defined as the ones directed to guest or namepsace, and
> outbound the ones originating from there.
> 
> Update comments for those two functions.
> 
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  tcp.c        | 2 +-
>  tcp_splice.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tcp.c b/tcp.c
> index 7e82589..63153b6 100644
> --- a/tcp.c
> +++ b/tcp.c
> @@ -3178,7 +3178,7 @@ void tcp_sock_init(const struct ctx *c, int ns, sa_family_t af,
>  }
>  
>  /**
> - * tcp_sock_init_ns() - Bind sockets in namespace for inbound connections
> + * tcp_sock_init_ns() - Bind sockets in namespace for outbound connections
>   * @arg:	Execution context
>   *
>   * Return: 0
> diff --git a/tcp_splice.c b/tcp_splice.c
> index 4a015d0..96c31c8 100644
> --- a/tcp_splice.c
> +++ b/tcp_splice.c
> @@ -502,7 +502,7 @@ static int tcp_splice_connect_ns(void *arg)
>  }
>  
>  /**
> - * tcp_splice_new() - Handle new inbound, spliced connection
> + * tcp_splice_new() - Handle new spliced connection
>   * @c:		Execution context
>   * @conn:	Connection pointer
>   * @port:	Destination port, host order

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]