From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id E8F7F5A0267 for ; Tue, 11 Oct 2022 03:23:54 +0200 (CEST) Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4MmdN750pyz4xGc; Tue, 11 Oct 2022 12:23:51 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1665451431; bh=zFANQS/elRYbdr6ma6qL3BOPleeWuYW4PjUG/UaTzCA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=j5wwirhgBLvTmIiY/JEe2bAX3fHt9hNkiPg4Vo7v2QJbZ+Mm28L6ZX3JCRrsW37EQ fb6TQEgSJtvpm24O3QjQIBmiv3O6NP6lFS3g57j+VFHiv1o9fLXoBmrvJ5KAsO7Znm M1t55NCyEAY1MrfkbnlceptsudSC50bGLQnT3zjw= Date: Tue, 11 Oct 2022 11:57:47 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 1/3] tcp, tcp_splice: Adjust comments to current meaning of inbound and outbound Message-ID: References: <20221010233350.1198630-1-sbrivio@redhat.com> <20221010233350.1198630-2-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gOUnSjU8/FoxW0H2" Content-Disposition: inline In-Reply-To: <20221010233350.1198630-2-sbrivio@redhat.com> Message-ID-Hash: LXS7D6SM6WNLSNNUHGW23TT4VXY7RPLW X-Message-ID-Hash: LXS7D6SM6WNLSNNUHGW23TT4VXY7RPLW X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: <> Archived-At: List-Archive: <> List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --gOUnSjU8/FoxW0H2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 11, 2022 at 01:33:48AM +0200, Stefano Brivio wrote: > For tcp_sock_init_ns(), "inbound" connections used to be the ones > being established toward any listening socket we create, as opposed > to sockets we connect(). >=20 > Similarly, tcp_splice_new() used to handle "inbound" connections in > the sense that they originated from listening sockets, and they would > in turn cause a connect() on an "outbound" socket. >=20 > Since commit 1128fa03fe73 ("Improve types and names for port > forwarding configuration"), though, inbound connections are more > broadly defined as the ones directed to guest or namepsace, and > outbound the ones originating from there. >=20 > Update comments for those two functions. >=20 > Signed-off-by: Stefano Brivio Reviewed-by: David Gibson > --- > tcp.c | 2 +- > tcp_splice.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/tcp.c b/tcp.c > index 7e82589..63153b6 100644 > --- a/tcp.c > +++ b/tcp.c > @@ -3178,7 +3178,7 @@ void tcp_sock_init(const struct ctx *c, int ns, sa_= family_t af, > } > =20 > /** > - * tcp_sock_init_ns() - Bind sockets in namespace for inbound connections > + * tcp_sock_init_ns() - Bind sockets in namespace for outbound connectio= ns > * @arg: Execution context > * > * Return: 0 > diff --git a/tcp_splice.c b/tcp_splice.c > index 4a015d0..96c31c8 100644 > --- a/tcp_splice.c > +++ b/tcp_splice.c > @@ -502,7 +502,7 @@ static int tcp_splice_connect_ns(void *arg) > } > =20 > /** > - * tcp_splice_new() - Handle new inbound, spliced connection > + * tcp_splice_new() - Handle new spliced connection > * @c: Execution context > * @conn: Connection pointer > * @port: Destination port, host order --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --gOUnSjU8/FoxW0H2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoULxWu4/Ws0dB+XtgypY4gEwYSIFAmNEv4UACgkQgypY4gEw YSLEHQ/+NSr5yYWN9sqQvRST0y6Nnz1inJllAtYnRWxlCbmoavQ5H6M20rMO3djl PBby2jlF2gz/UkChWnGdHEZnLsS9hvs/Y56Y0sqlrlPugjrRqGCUBSde/GDs6F0B cezAQYqOFx2EA6oRKLcHsIEpGIk5I1Lrp7iulXl2RSwsUinb7/f31lLSrU+/KLd+ jDmshqD9mzZpNXyvjBN6EbvPcDfhPinOVDVqSU5kU4Ro87XjcdNfPtWj24GvefgD m48WO240Mudxz4dKeAldt4hgqdilWKz/dTH6BH2E8e1EBq3Df6F5tPau9pkzueZS 8j9KWonZd2ZceLE40hlt9PB+N5wfM5qI+ln2REdgthtV+86hf+/E6hx2GM4cLdyn B7oSWJfTGYv5xO0nIIhCkOaQ/heOizAAR0bL5dnBN6ZfCBQ6TX2ps0ZQRb2F4pu0 TXOMWgMbkw82jufVuXdsXQ/rrxs4pEu/eJV0f53CuJtYZ5iuSTXLH3eXbkZh460g EkiCDBSwnysI2FAZY5qsJbf7dT1t1uFA3582I67KZEZcpXz81I5rNm5NJGOPW766 1+b+mSAjV2UPgT3Lj4UmDCMON6ypJ2GO5TscPKh3QehgE1iu6vm9XGQN2nWGBp0B kdLNoVwcBbv8gfIc74AH+PiNBBZM1X8EL53XqNInjMZNVbUphjQ= =eQae -----END PGP SIGNATURE----- --gOUnSjU8/FoxW0H2--