From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] conf: Drop excess colons in usage for DHCP and DNS options
Date: Tue, 11 Oct 2022 11:52:16 +1100 [thread overview]
Message-ID: <Y0S+QHDXOjoQQM4P@yekko> (raw)
In-Reply-To: <20221010233315.1198386-1-sbrivio@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1436 bytes --]
On Tue, Oct 11, 2022 at 01:33:15AM +0200, Stefano Brivio wrote:
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> conf.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/conf.c b/conf.c
> index c2634fc..b1b7c63 100644
> --- a/conf.c
> +++ b/conf.c
> @@ -693,14 +693,14 @@ static void usage(const char *name)
> info( " default: use search list from /etc/resolv.conf");
>
> if (strstr(name, "pasta"))
> - info(" --dhcp-dns: \tPass DNS list via DHCP/DHCPv6/NDP");
> + info(" --dhcp-dns \tPass DNS list via DHCP/DHCPv6/NDP");
> else
> - info(" --no-dhcp-dns: No DNS list in DHCP/DHCPv6/NDP");
> + info(" --no-dhcp-dns No DNS list in DHCP/DHCPv6/NDP");
>
> if (strstr(name, "pasta"))
> - info(" --dhcp-search: Pass list via DHCP/DHCPv6/NDP");
> + info(" --dhcp-search Pass list via DHCP/DHCPv6/NDP");
> else
> - info(" --no-dhcp-search: No list in DHCP/DHCPv6/NDP");
> + info(" --no-dhcp-search No list in DHCP/DHCPv6/NDP");
>
> info( " --dns-forward ADDR Forward DNS queries sent to ADDR");
> info( " can be specified zero to two times (for IPv4 and IPv6)");
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-10-11 1:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 23:33 [PATCH] conf: Drop excess colons in usage for DHCP and DNS options Stefano Brivio
2022-10-11 0:52 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0S+QHDXOjoQQM4P@yekko \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).