* [PATCH] conf: Drop excess colons in usage for DHCP and DNS options
@ 2022-10-10 23:33 Stefano Brivio
2022-10-11 0:52 ` David Gibson
0 siblings, 1 reply; 2+ messages in thread
From: Stefano Brivio @ 2022-10-10 23:33 UTC (permalink / raw)
To: passt-dev
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
conf.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/conf.c b/conf.c
index c2634fc..b1b7c63 100644
--- a/conf.c
+++ b/conf.c
@@ -693,14 +693,14 @@ static void usage(const char *name)
info( " default: use search list from /etc/resolv.conf");
if (strstr(name, "pasta"))
- info(" --dhcp-dns: \tPass DNS list via DHCP/DHCPv6/NDP");
+ info(" --dhcp-dns \tPass DNS list via DHCP/DHCPv6/NDP");
else
- info(" --no-dhcp-dns: No DNS list in DHCP/DHCPv6/NDP");
+ info(" --no-dhcp-dns No DNS list in DHCP/DHCPv6/NDP");
if (strstr(name, "pasta"))
- info(" --dhcp-search: Pass list via DHCP/DHCPv6/NDP");
+ info(" --dhcp-search Pass list via DHCP/DHCPv6/NDP");
else
- info(" --no-dhcp-search: No list in DHCP/DHCPv6/NDP");
+ info(" --no-dhcp-search No list in DHCP/DHCPv6/NDP");
info( " --dns-forward ADDR Forward DNS queries sent to ADDR");
info( " can be specified zero to two times (for IPv4 and IPv6)");
--
@@ -693,14 +693,14 @@ static void usage(const char *name)
info( " default: use search list from /etc/resolv.conf");
if (strstr(name, "pasta"))
- info(" --dhcp-dns: \tPass DNS list via DHCP/DHCPv6/NDP");
+ info(" --dhcp-dns \tPass DNS list via DHCP/DHCPv6/NDP");
else
- info(" --no-dhcp-dns: No DNS list in DHCP/DHCPv6/NDP");
+ info(" --no-dhcp-dns No DNS list in DHCP/DHCPv6/NDP");
if (strstr(name, "pasta"))
- info(" --dhcp-search: Pass list via DHCP/DHCPv6/NDP");
+ info(" --dhcp-search Pass list via DHCP/DHCPv6/NDP");
else
- info(" --no-dhcp-search: No list in DHCP/DHCPv6/NDP");
+ info(" --no-dhcp-search No list in DHCP/DHCPv6/NDP");
info( " --dns-forward ADDR Forward DNS queries sent to ADDR");
info( " can be specified zero to two times (for IPv4 and IPv6)");
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] conf: Drop excess colons in usage for DHCP and DNS options
2022-10-10 23:33 [PATCH] conf: Drop excess colons in usage for DHCP and DNS options Stefano Brivio
@ 2022-10-11 0:52 ` David Gibson
0 siblings, 0 replies; 2+ messages in thread
From: David Gibson @ 2022-10-11 0:52 UTC (permalink / raw)
To: Stefano Brivio; +Cc: passt-dev
[-- Attachment #1: Type: text/plain, Size: 1436 bytes --]
On Tue, Oct 11, 2022 at 01:33:15AM +0200, Stefano Brivio wrote:
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> conf.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/conf.c b/conf.c
> index c2634fc..b1b7c63 100644
> --- a/conf.c
> +++ b/conf.c
> @@ -693,14 +693,14 @@ static void usage(const char *name)
> info( " default: use search list from /etc/resolv.conf");
>
> if (strstr(name, "pasta"))
> - info(" --dhcp-dns: \tPass DNS list via DHCP/DHCPv6/NDP");
> + info(" --dhcp-dns \tPass DNS list via DHCP/DHCPv6/NDP");
> else
> - info(" --no-dhcp-dns: No DNS list in DHCP/DHCPv6/NDP");
> + info(" --no-dhcp-dns No DNS list in DHCP/DHCPv6/NDP");
>
> if (strstr(name, "pasta"))
> - info(" --dhcp-search: Pass list via DHCP/DHCPv6/NDP");
> + info(" --dhcp-search Pass list via DHCP/DHCPv6/NDP");
> else
> - info(" --no-dhcp-search: No list in DHCP/DHCPv6/NDP");
> + info(" --no-dhcp-search No list in DHCP/DHCPv6/NDP");
>
> info( " --dns-forward ADDR Forward DNS queries sent to ADDR");
> info( " can be specified zero to two times (for IPv4 and IPv6)");
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-11 1:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-10 23:33 [PATCH] conf: Drop excess colons in usage for DHCP and DNS options Stefano Brivio
2022-10-11 0:52 ` David Gibson
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).