From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] util.h: Add missing gcc pragma push before pragma pop
Date: Thu, 13 Oct 2022 12:14:49 +1100 [thread overview]
Message-ID: <Y0dmiaXtCuaRwjC4@yekko> (raw)
In-Reply-To: <20221012154540.1650617-1-sbrivio@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 887 bytes --]
On Wed, Oct 12, 2022 at 05:45:40PM +0200, Stefano Brivio wrote:
> While building with clang:
>
> ./util.h:176:24: warning: pragma diagnostic pop could not pop, no matching push [-Wunknown-pragmas]
>
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> util.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/util.h b/util.h
> index b1eadfd..4d1b375 100644
> --- a/util.h
> +++ b/util.h
> @@ -165,6 +165,7 @@
> struct ctx;
>
> struct ipv6hdr {
> +#pragma GCC diagnostic push
> #pragma GCC diagnostic ignored "-Wpedantic"
> #if __BYTE_ORDER == __BIG_ENDIAN
> uint8_t version:4,
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-10-13 4:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 15:45 [PATCH] util.h: Add missing gcc pragma push before pragma pop Stefano Brivio
2022-10-13 1:14 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0dmiaXtCuaRwjC4@yekko \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).