Re: [PATCH 2/4] tap: Trace received (outbound) ICMP packets in debug mode, too

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]

On Wed, Oct 26, 2022 at 06:25:29PM +0200, Stefano Brivio wrote:
> This only worked for ICMPv6: ICMP packets have no TCP-style header,
> so they are handled as a special case before packet sequences are
> formed, and the call to tap_packet_debug() was missing.
> 
> Fixes: bb708111833e ("treewide: Packet abstraction with mandatory boundary checks")
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  tap.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tap.c b/tap.c
> index 3f78c99..4dcff4f 100644
> --- a/tap.c
> +++ b/tap.c
> @@ -463,6 +463,8 @@ resume:
>  			if (c->no_icmp)
>  				continue;
>  
> +			tap_packet_debug(iph, NULL, NULL, 0, NULL, 1);
> +
>  			packet_add(pkt, l4_len, l4h);
>  			icmp_tap_handler(c, AF_INET, &iph->daddr, pkt, now);
>  			continue;

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]