From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 608D95A0265 for ; Thu, 27 Oct 2022 00:08:34 +0200 (CEST) Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4MyNHJ2c8Nz4xGd; Thu, 27 Oct 2022 09:08:28 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1666822108; bh=0lDdo6p2L0H1ogm6f8WEX3eUa0DafhVVRtBRfXEESgg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cHugZJHdGZzJx93Ed6PbRgP/xalgmWP5cyjf3zGhjIcIb2WlN+UnWCu6CWiaa+J9q X38caAAdknkjs01cBk2qexybRA0te/kAj5KHqe/fA0F1+h0MWKOyoP8mOu+LdeoZGZ we0fYrD090vGMQ69dglrzPBdVw4m5h/ncgPcjFKA= Date: Thu, 27 Oct 2022 08:55:50 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 2/4] tap: Trace received (outbound) ICMP packets in debug mode, too Message-ID: References: <20221026162531.545374-1-sbrivio@redhat.com> <20221026162531.545374-3-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bLvcY5G1NM7KZts0" Content-Disposition: inline In-Reply-To: <20221026162531.545374-3-sbrivio@redhat.com> Message-ID-Hash: 77WJMBYFCW35UBZVGRJYIXFLKXMOYCDR X-Message-ID-Hash: 77WJMBYFCW35UBZVGRJYIXFLKXMOYCDR X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Paul Holzinger X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: <> Archived-At: List-Archive: <> List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --bLvcY5G1NM7KZts0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 26, 2022 at 06:25:29PM +0200, Stefano Brivio wrote: > This only worked for ICMPv6: ICMP packets have no TCP-style header, > so they are handled as a special case before packet sequences are > formed, and the call to tap_packet_debug() was missing. >=20 > Fixes: bb708111833e ("treewide: Packet abstraction with mandatory boundar= y checks") > Signed-off-by: Stefano Brivio Reviewed-by: David Gibson > --- > tap.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/tap.c b/tap.c > index 3f78c99..4dcff4f 100644 > --- a/tap.c > +++ b/tap.c > @@ -463,6 +463,8 @@ resume: > if (c->no_icmp) > continue; > =20 > + tap_packet_debug(iph, NULL, NULL, 0, NULL, 1); > + > packet_add(pkt, l4_len, l4h); > icmp_tap_handler(c, AF_INET, &iph->daddr, pkt, now); > continue; --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --bLvcY5G1NM7KZts0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoULxWu4/Ws0dB+XtgypY4gEwYSIFAmNZrN8ACgkQgypY4gEw YSLmdBAAl4DClfPUVOG0/S1YZGWNiLjugKicWYAukl5Mwi/uS0PGgz1bgmGmU7IQ YZltqYRmU2UXGrz/fNZ8JFHWD+4kp74zSit0w4ZJgc5Wjjkt9X1MysXe/V0dvD73 QZBTWuq5fAQBYDmH/uX+mwYpYQYKuIFirkJy9Y+s/TLMyNPVf6ntQQeiHI3dmBEk i06BR3UocXBHFCJ/QWHf2HdcFCKrjYuNeuFFDTbSLdJBYNIPUdbznEqAsP4a6aLh mpybTYGEmlf6NK36z39AShsAnffMoWkiHUww+eL2Tg6Q2OM2qR6t9g4yYNUaZjAw 47dTAb+pnTOv6aRvaQT3N8DauH/jpNdh2PTq+QRzBSSWK1uWVVHYKmELl7Qcr/CE FFKNUBNY7woG5hPyE79UWoFtcXk2ldAg4SWOs63RoPMslKxjnT1oND43Skp5wtIt 3W90POTQgThJ7fXHis/b4Wty3nogZNmb7NXJf1Pgkgu9sDxBKi5xMcPWDiNecGFO cASDBFMDXpdVq4FmcqBvVFKfFz43gam8j/eBwtANZwE8u+2ksvf3VZ8dHsAT8MsX rQf7bJgPt9zrUnSq35tTyin6w/iqNzYo5J7S9FbS5bdc0OQHQyA4VyqgP2cQdqJn JV1h3q0jRWdKUF5wwxNTB9mcSxCAiQjQP3WPpZQAvqSmDYBKiLA= =zomu -----END PGP SIGNATURE----- --bLvcY5G1NM7KZts0--