From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 207D05A0265 for ; Thu, 27 Oct 2022 00:08:32 +0200 (CEST) Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4MyNHJ2Vq7z4xGZ; Thu, 27 Oct 2022 09:08:28 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1666822108; bh=yfA71I3yrbV2w4E2+vF9IndByIguclGRfmHv/SIGA4g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K84KGK+L29d8tpYuODzRHu4VwK5mYvr8+JfX7bGfxzSU9WXyQe11RLa8SRLFmd6ds V/fhyrG2ovcqSQBQRwszuhxWtb6zd2+U2O0MHcBJPR/pqtUMbEfyL74lV5IjOPhnNj h4o7lBqdJSu3jO2NgNDZBBW1CQhSiKd+Bk8WKIQw= Date: Thu, 27 Oct 2022 08:52:21 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 1/4] conf, passt.1: Don't imply --foreground with --debug Message-ID: References: <20221026162531.545374-1-sbrivio@redhat.com> <20221026162531.545374-2-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="thxCM9ITnXHAMseL" Content-Disposition: inline In-Reply-To: <20221026162531.545374-2-sbrivio@redhat.com> Message-ID-Hash: E336E3IKJ6FKTCFIYFADHIVT7VLQHYXP X-Message-ID-Hash: E336E3IKJ6FKTCFIYFADHIVT7VLQHYXP X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Paul Holzinger X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: <> Archived-At: List-Archive: <> List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --thxCM9ITnXHAMseL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 26, 2022 at 06:25:28PM +0200, Stefano Brivio wrote: > Having -f implied by -d (and --trace) usually saves some typing, but > debug mode in background (with a log file) is quite useful if pasta > is started by Podman, and is probably going to be handy for passt > with libvirt later, too. >=20 > Signed-off-by: Stefano Brivio Reviewed-by: David Gibson > --- > conf.c | 7 +++---- > passt.1 | 5 ++--- > 2 files changed, 5 insertions(+), 7 deletions(-) >=20 > diff --git a/conf.c b/conf.c > index 598c711..90214f5 100644 > --- a/conf.c > +++ b/conf.c > @@ -636,7 +636,7 @@ static void usage(const char *name) > info(""); > =20 > =20 > - info( " -d, --debug Be verbose, don't run in background"); > + info( " -d, --debug Be verbose"); > info( " --trace Be extra verbose, implies --debug"); > info( " -q, --quiet Don't print informational messages"); > info( " -f, --foreground Don't run in background"); > @@ -1192,7 +1192,7 @@ void conf(struct ctx *c, int argc, char **argv) > usage(argv[0]); > } > =20 > - c->trace =3D c->debug =3D c->foreground =3D 1; > + c->trace =3D c->debug =3D 1; > break; > case 12: > if (runas) { > @@ -1233,7 +1233,6 @@ void conf(struct ctx *c, int argc, char **argv) > } > =20 > c->debug =3D 1; > - c->foreground =3D 1; > break; > case 'e': > if (logfile) { > @@ -1275,7 +1274,7 @@ void conf(struct ctx *c, int argc, char **argv) > c->quiet =3D 1; > break; > case 'f': > - if (c->foreground && !c->debug) { > + if (c->foreground) { > err("Multiple --foreground options given"); > usage(argv[0]); > } > diff --git a/passt.1 b/passt.1 > index 92c4ce2..d121050 100644 > --- a/passt.1 > +++ b/passt.1 > @@ -79,12 +79,11 @@ for performance reasons. > =20 > .TP > .BR \-d ", " \-\-debug > -Be verbose, don't run in background, don't log to the system logger. > +Be verbose, don't log to the system logger. > =20 > .TP > .BR \-\-trace > -Be extra verbose, show single packets, don't run in background. Implies > -\fB--debug\fR. > +Be extra verbose, show single packets. Implies \fB--debug\fR. > =20 > .TP > .BR \-q ", " \-\-quiet --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --thxCM9ITnXHAMseL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoULxWu4/Ws0dB+XtgypY4gEwYSIFAmNZq/sACgkQgypY4gEw YSLIfQ/+Kq+vjC7Xq1p0iqNh7ByPyeN6mEpXDNjHkR6687cRkV7LGqPOnzipizL4 RIyeyZWBW86f+DHPBU64LxNRy8PLlqGDGlFGEVQYaO8PYTgPXwiD2xPDIDqZJD3K 7DfI0zfP/E/D/VU94ifZCH+29TQzfAmvlKOE0izsVWJe7Sm4+xeV3AE7Pux48nti jNcfTlVj5z7lBDJmZbsiLqwUY+H2J8TGRG/HsXwku3Zq1ZYDvQ49hIPM7Gs4VIfP Y02vqezYqAeXlk/KC/VU9GlVbnrB+XzOKN/MNBh+kJ+72hY7k+0rcBVpc0ekzSAZ 7xNHENuGU61xrKA7yH9JvEefImf5F0HH8Pwjs/p+4bY2jZhWmrG7XXZ0hxp2r9oF 5COhPneowvgp0qcqOSBuAiOLNfREJpY5RnqvEaNuVXEHZwHK/vZASPCcwou/oD/U L+3ECQwfBIB5a7vi+IQ4KWSjTEjuCB0dqN32TvPTe/JTeEZyR3p1GCK9KpEljIC0 QTXQgzp9sxyowZfk24xA4h+JUgmqEHK0iITRAfc/HRp5dVvP6O+RefbOQFIPWGae ne491ogOebQWSwfSWbb/zIxNNSYSTSCWQVvd7r881HQk10/3PIR3oanhsWnbchAJ WOtH37g2GvKwS92p10wja1CpF2P+qHKUZpNAieEENuDlPfkoW20= =Z8Cs -----END PGP SIGNATURE----- --thxCM9ITnXHAMseL--