public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] test/run: Temporarily disable distribution tests
Date: Thu, 27 Oct 2022 09:11:34 +1100	[thread overview]
Message-ID: <Y1mwljzMgRWs37vW@yekko> (raw)
In-Reply-To: <20221026051218.1842125-1-sbrivio@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]

On Wed, Oct 26, 2022 at 07:12:18AM +0200, Stefano Brivio wrote:
11;rgb:ffff/ffff/ffff> They're too slow to cope with current release cycles, and they
> haven't found bugs in months, also because clang-tidy and cppcheck
> would find most of them earlier.
> 
> Disable them for the moment. We should pre-install gcc and make in
> non-x86 images, as those run on my test machine with qemu TCG, and
> that's the real slow-down here. Then we can re-enable them.
> 
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  test/run | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/test/run b/test/run
> index d61b2d3..cb3b6c0 100755
> --- a/test/run
> +++ b/test/run
> @@ -110,12 +110,16 @@ run() {
>  	test passt_in_ns/shutdown
>  	teardown passt_in_ns
>  
> +	# TODO: Make those faster by at least pre-installing gcc and make on
> +	# non-x86 images, then re-enable.
> +skip_distro() {
>  	setup distro
>  	test distro/debian
>  	test distro/fedora
>  	test distro/opensuse
>  	test distro/ubuntu
>  	teardown distro
> +}
>  
>  	perf_finish
>  	[ ${CI} -eq 1 ] && video_stop

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2022-10-26 22:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-26  5:12 [PATCH] test/run: Temporarily disable distribution tests Stefano Brivio
2022-10-26 22:11 ` David Gibson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y1mwljzMgRWs37vW@yekko \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).