[PATCH] test/run: Temporarily disable distribution tests

[PATCH] test/run: Temporarily disable distribution tests

[Stefano Brivio]

They're too slow to cope with current release cycles, and they
haven't found bugs in months, also because clang-tidy and cppcheck
would find most of them earlier.

Disable them for the moment. We should pre-install gcc and make in
non-x86 images, as those run on my test machine with qemu TCG, and
that's the real slow-down here. Then we can re-enable them.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
---
 test/run | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/test/run b/test/run
index d61b2d3..cb3b6c0 100755
--- a/test/run
+++ b/test/run
@@ -110,12 +110,16 @@ run() {
 	test passt_in_ns/shutdown
 	teardown passt_in_ns
 
+	# TODO: Make those faster by at least pre-installing gcc and make on
+	# non-x86 images, then re-enable.
+skip_distro() {
 	setup distro
 	test distro/debian
 	test distro/fedora
 	test distro/opensuse
 	test distro/ubuntu
 	teardown distro
+}
 
 	perf_finish
 	[ ${CI} -eq 1 ] && video_stop
-- 
@@ -110,12 +110,16 @@ run() {
 	test passt_in_ns/shutdown
 	teardown passt_in_ns
 
+	# TODO: Make those faster by at least pre-installing gcc and make on
+	# non-x86 images, then re-enable.
+skip_distro() {
 	setup distro
 	test distro/debian
 	test distro/fedora
 	test distro/opensuse
 	test distro/ubuntu
 	teardown distro
+}
 
 	perf_finish
 	[ ${CI} -eq 1 ] && video_stop
-- 
2.35.1

Re: [PATCH] test/run: Temporarily disable distribution tests

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]

On Wed, Oct 26, 2022 at 07:12:18AM +0200, Stefano Brivio wrote:
11;rgb:ffff/ffff/ffff> They're too slow to cope with current release cycles, and they
> haven't found bugs in months, also because clang-tidy and cppcheck
> would find most of them earlier.
> 
> Disable them for the moment. We should pre-install gcc and make in
> non-x86 images, as those run on my test machine with qemu TCG, and
> that's the real slow-down here. Then we can re-enable them.
> 
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  test/run | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/test/run b/test/run
> index d61b2d3..cb3b6c0 100755
> --- a/test/run
> +++ b/test/run
> @@ -110,12 +110,16 @@ run() {
>  	test passt_in_ns/shutdown
>  	teardown passt_in_ns
>  
> +	# TODO: Make those faster by at least pre-installing gcc and make on
> +	# non-x86 images, then re-enable.
> +skip_distro() {
>  	setup distro
>  	test distro/debian
>  	test distro/fedora
>  	test distro/opensuse
>  	test distro/ubuntu
>  	teardown distro
> +}
>  
>  	perf_finish
>  	[ ${CI} -eq 1 ] && video_stop

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]