Re: [PATCH v2 4/5] test/lib: Add "td" directive, handled by table_value()

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 2331 bytes --]

On Mon, Oct 31, 2022 at 12:20:58PM +0100, Stefano Brivio wrote:
> This can be used for generic cell values with an arbitrary scale.
> 
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  test/lib/term | 28 ++++++++++++++++++++++++++++
>  test/lib/test |  3 +++
>  2 files changed, 31 insertions(+)
> 
> diff --git a/test/lib/term b/test/lib/term
> index 1b42df8..8515c50 100755
> --- a/test/lib/term
> +++ b/test/lib/term
> @@ -552,6 +552,34 @@ table_end() {
>  	info_n "\n${__buf}'\n"
>  }
>  
> +# table_value() - Print generic table value in its own cell
> +# $1:	Value, can be '-' to indicate a filler
> +# $2:	Scale, exponent of 10
> +# $3:	Error value, scaled: if value is less than this, print in red
> +# $4:	Warning value, scaled: if value is less than this, print in yellow
> +table_value() {
> +	[ "${1}" = "-" ] && table_cell 1 "-" && perf_td 0 "" && return 0
> +	if [ "${2}" != "0" ]; then
> +		__v="$(echo "scale=1; x=( ${1} + 10^$((${2} - 1)) / 2 ) / 10^${2}; if ( x < 1 && x > 0 ) print 0; x" | bc -l)"
> +	else
> +		__v="${1}"
> +	fi
> +	perf_td 0 "${__v}"
> +
> +	__red="${3}"
> +	__yellow="${4}"
> +	if [ "$(echo "${__v} < ${__red}" | bc -l)" = "1" ]; then
> +		table_cell ${#__v} "${PR_RED}${__v}${PR_NC}"
> +		return 1
> +	elif [ "$(echo "${__v} < ${__yellow}" | bc -l)" = "1" ]; then
> +		table_cell ${#__v} "${PR_YELLOW}${__v}${PR_NC}"
> +		return 1
> +	else
> +		table_cell ${#__v} "${PR_GREEN}${__v}${PR_NC}"
> +		return 0
> +	fi
> +}
> +
>  table_value_throughput() {
>  	[ "${1}" = "-" ] && table_cell 1 "-" && perf_td 0 "" && return 0
>  	__v="$(echo "scale=1; x=( ${1} + 10^8 / 2 ) / 10^9; if ( x < 1 && x > 0 ) print 0; x" | bc -l)"
> diff --git a/test/lib/test b/test/lib/test
> index 4c271a5..df32178 100755
> --- a/test/lib/test
> +++ b/test/lib/test
> @@ -278,6 +278,9 @@ test_one_line() {
>  	"te")
>  		table_end
>  		;;
> +	"td")
> +		table_value ${__arg} || TEST_ONE_perf_nok=1
> +		;;
>  	"bw")
>  		table_value_throughput ${__arg} || TEST_ONE_perf_nok=1
>  		;;

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]