public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] test: Wait for network before starting passt in two_guests setup
Date: Mon, 7 Nov 2022 14:54:26 +1100	[thread overview]
Message-ID: <Y2iBcknjX+B8ZFFt@yekko> (raw)
In-Reply-To: <Y2h5uqt+ssMWaLpm@yekko>

[-- Attachment #1: Type: text/plain, Size: 2104 bytes --]

On Mon, Nov 07, 2022 at 02:21:30PM +1100, David Gibson wrote:
> On Fri, Nov 04, 2022 at 02:53:36AM +0100, Stefano Brivio wrote:
> > As pasta now configures that target network namespace with
> > --config-net, we need to wait for addresses and routes to be actually
> > present. Just sending netlink messages doesn't mean this is done
> > synchronously.
> > 
> > A more elegant alternative, which probably makes sense regardless of
> > this test setup, would be to query, from pasta, addresses and routes
> > we added, and wait until they're there, before proceeding.
> > 
> > Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
> 
> Ugly, but I see the point.

Oops, forgot to add

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> 
> As you say in future I hope we can actually detect the completion of
> interface configuration which would be useful both here and other
> places.
> 
> One other thing to consider - in the case where pasta is spawing a new
> process, rather than attaching to an existing one, it's possibly
> counterintuitive that the process starts before pasta has completed
> setup.  We possibly should get the spawned thread to wait until the
> main pasta thread is entering its main loop before exec()ing the
> shell.  Obviously requires some sync mechanism, which is a bit clunky.
> 
> > ---
> >  test/lib/setup | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/test/lib/setup b/test/lib/setup
> > index ab6d8d5..07d5056 100755
> > --- a/test/lib/setup
> > +++ b/test/lib/setup
> > @@ -208,6 +208,8 @@ setup_two_guests() {
> >  
> >  	__ifname="$(context_run qemu_1 "ip -j link show | jq -rM '.[] | select(.link_type == \"ether\").ifname'")"
> >  
> > +	sleep 1
> > +
> >  	__opts=
> >  	[ ${PCAP} -eq 1 ] && __opts="${__opts} -p ${LOGDIR}/passt_1.pcap"
> >  	[ ${DEBUG} -eq 1 ] && __opts="${__opts} -d"
> 



-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2022-11-07  3:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-04  1:53 [PATCH] test: Wait for network before starting passt in two_guests setup Stefano Brivio
2022-11-07  3:21 ` David Gibson
2022-11-07  3:54   ` David Gibson [this message]
2022-11-07  9:51   ` Stefano Brivio
2022-11-07 18:59     ` Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2iBcknjX+B8ZFFt@yekko \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).