From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id D86135A0082 for ; Tue, 15 Nov 2022 05:57:59 +0100 (CET) Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4NBDSx1drqz4xYV; Tue, 15 Nov 2022 15:57:53 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1668488273; bh=9NbJl28tICnSEbKlN/UIyhs9tNLRSYBzW9IVDyqH9B4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ofreAx44ITDX1tinni6V7ej8cb5AdrF8sow3txPjy3XcPjZr8d5A2VEqblUsPN5UC FKePM1SLz/SjmLI5smE5AMi7z2Q43sa/JTxnS1ut2yVzlzeWxeVALfh9tkdGft7Dmf OGrm0n4t5OgPmdPxE/eXctfmDIancO0eLu8ttPFw= Date: Tue, 15 Nov 2022 15:57:46 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 00/14] RFC: tcp: Don't use separate listening sockets for spliced and non-spliced connections Message-ID: References: <20221114061711.1655510-1-david@gibson.dropbear.id.au> <20221115022242.21235140@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mc58QUY8oOZEohcA" Content-Disposition: inline In-Reply-To: <20221115022242.21235140@elisabeth> Message-ID-Hash: HQMIDAURLDN3FJRLWKXGIUFSQBJBQD6B X-Message-ID-Hash: HQMIDAURLDN3FJRLWKXGIUFSQBJBQD6B X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --mc58QUY8oOZEohcA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 15, 2022 at 02:22:41AM +0100, Stefano Brivio wrote: > On Mon, 14 Nov 2022 17:16:57 +1100 > David Gibson wrote: >=20 > > We can splice TCP connections in pasta mode if and only if they > > originate from localhost. Currently we separate the two cases by > > having separate listening sockets: one listens on the host address for > > non-spliceable connections, the other listens on the loopback address > > for spliceable connections. >=20 > I couldn't finish reviewing the whole series in detail yet, but I had a > look at all the patches and, except for a couple of minor style issues > (those are the ones I still need to finish checking), I couldn't see any > flaw -- all the single patches look fine to me. Ok. Probably not worth looking deeper at this stage. I'm pretty close to sending a new series which contains a slightly revised version of this, plus the rest of the stuff necessary to do dual stack TCP sockets. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --mc58QUY8oOZEohcA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoULxWu4/Ws0dB+XtgypY4gEwYSIFAmNzHEMACgkQgypY4gEw YSLtjg/+JiQd9bcyQTNTNLzNpMW9D24ZYVsCA6SkokCbXZ6+EVt4LT8GQV98xPb2 IFT21pRBJQBNuQsoK3KP2N2sMOZlIaWTJpYodcz5TYIRBW/0r/q57f7BoBJ9Qfkj UPNWlg6KUtp7TlcMvlp+MVJZOwlnqMd3Y7dkVkoO7a5Lh9x7ci8NbuGagvBWgQM9 piSlVS1EfhzNerRqEnQGogsemfrAC2YnJchBLjDWn3VIVFMQe2z8g1+5RsMHtrIs sNzqbKY0piF7Tv5hmBrTa5TzXjiVSdOH/JvfkvaDm/MGqZlcwZCnk5cmqgGEC8qA ls2CepNl4hYroJ21cNNF0NQdZSNwHfTIVb4iAV0HYlKRSkYXcWFnXL3ft+piyr4Z RuKj2eRYfcmTK2a8cKmcZLb8VPni6n0Ol0XKaIPVYuZeCuI36q9+eDvQk9EuAfwO 2urH69GPxhJAAw802ty0I8Yq300f+QmwSViSOsSyF4moFNvdWmC/km/jfgQwoEMm jtWMcY5RyL6YS+eChKGf97PvBP63N+++c3IiRb4CIztvBhQ3xWvjGMdXhAd5vnut o/IMpZW3qCWybJnPO+XuUBe0TtTIXnp7bZjg7CkWJOUx9p5nOYpkskfjFuh12ALo y2cD6a6+HszIRUQr2A+NQyIMGj9USyq+mJdzi1m7O+A5WLzqiCY= =z/sH -----END PGP SIGNATURE----- --mc58QUY8oOZEohcA--