On Tue, Nov 15, 2022 at 02:23:43AM +0100, Stefano Brivio wrote:
> Drop it from the internal FLAGS variable, but honour -O2 if passed in
> CFLAGS. In Debian packages, dpkg-buildflags uses it as hardening
> flag, and we get a QA warning if we drop it:
>   https://qa.debian.org/bls/bytag/W-dpkg-buildflags-missing.html
>
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index a6e3164..f0b8e1d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -125,7 +125,7 @@ passt: $(PASST_SRCS) $(HEADERS)
>  
>  passt.avx2: FLAGS += -Ofast -mavx2 -ftree-vectorize -funroll-loops
>  passt.avx2: $(PASST_SRCS) $(HEADERS)
> -	$(CC) $(filter-out -O2,$(FLAGS) $(CFLAGS) $(CPPFLAGS)) \
> +	$(CC) $(filter-out -O2,$(FLAGS)) $(CFLAGS) $(CPPFLAGS) \
>  		$(PASST_SRCS) -o passt.avx2 $(LDFLAGS)
>  
>  passt.avx2: passt

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson