From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 1F8CA5A005E for ; Tue, 15 Nov 2022 10:22:14 +0100 (CET) Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4NBLKr3dTkz4xZZ; Tue, 15 Nov 2022 20:22:08 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1668504128; bh=/t2JIpFvSWUbDIBFDit/+QAlgWTUsEX6oi/Fmx3wNqY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bkc71rU8uwZx962fWzv1f77IlKBb5jvUeC43yOtBmRZ8MCLCHTqCSqltTbIuobbTI WWqPhkdIKp+40udbcE3qiGiqkjLpC8zgF5UMP+jkCahyY9Z5c4EjRfPuPn6PJmbdIs lKxheT+J/5S0UqhfFEFpwzo4GaDLC4jKMmdEklHQ= Date: Tue, 15 Nov 2022 16:15:32 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 2/8] Makefile: Don't filter out -O2 from supplied flags for AVX2 builds Message-ID: References: <20221115012349.2240096-1-sbrivio@redhat.com> <20221115012349.2240096-3-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GR6CwbWmoWwTd7w4" Content-Disposition: inline In-Reply-To: <20221115012349.2240096-3-sbrivio@redhat.com> Message-ID-Hash: Z7BZJTK5TERCCFYSLZ6HEND4ZEHX7WB3 X-Message-ID-Hash: Z7BZJTK5TERCCFYSLZ6HEND4ZEHX7WB3 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --GR6CwbWmoWwTd7w4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 15, 2022 at 02:23:43AM +0100, Stefano Brivio wrote: > Drop it from the internal FLAGS variable, but honour -O2 if passed in > CFLAGS. In Debian packages, dpkg-buildflags uses it as hardening > flag, and we get a QA warning if we drop it: > https://qa.debian.org/bls/bytag/W-dpkg-buildflags-missing.html > > Signed-off-by: Stefano Brivio Reviewed-by: David Gibson > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/Makefile b/Makefile > index a6e3164..f0b8e1d 100644 > --- a/Makefile > +++ b/Makefile > @@ -125,7 +125,7 @@ passt: $(PASST_SRCS) $(HEADERS) > =20 > passt.avx2: FLAGS +=3D -Ofast -mavx2 -ftree-vectorize -funroll-loops > passt.avx2: $(PASST_SRCS) $(HEADERS) > - $(CC) $(filter-out -O2,$(FLAGS) $(CFLAGS) $(CPPFLAGS)) \ > + $(CC) $(filter-out -O2,$(FLAGS)) $(CFLAGS) $(CPPFLAGS) \ > $(PASST_SRCS) -o passt.avx2 $(LDFLAGS) > =20 > passt.avx2: passt --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --GR6CwbWmoWwTd7w4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoULxWu4/Ws0dB+XtgypY4gEwYSIFAmNzIG4ACgkQgypY4gEw YSKVjBAAkPjYDQW/Vmu9v30rehWmDy+Z678f7RYRlO6SyiWSORkUI+djrLhutisd 9cDcB/PTUKNPdpsBOmvdTsSBTnXagzsn7rCxJkXRcjT397sXNkAJXVuINlbY8oTo jDvaGImQoxELpB+kMIiyPnD422AhWiwt6Z0ogcHobdFmxSwIp1D9wi/aW/8Bw1yM //CYMGOYW1+a6Kp56A7oqrjZr2fGamBUq5SGb+/6+fCWD8oKdsLyQEFfd7EDFjVZ 6N/CXaAWs2P+ZnYqsXQlZs0RR8fRKaMJISrOPTi00O1rBml37RFWIz+Nn8vpK+aL 7wL5iSAUYDofdbUexkWQKaTyxa5Ylqf0PN63pWe3cu3ZKtGJrsHKqFPS9/SftW+S l+NbSw+lqAtCq7aTAGJX/SCnrb36qql/tamtxgqHIrjFCfPwRyb7lz3ItunFtHq2 eTp+T9t2P4AKsmRCy/fCFlODIqvIdyohvtxvPd0uSz2PmRc92+jkkikBaO6JT031 txfo8JtHP5/UkanL53tqDZZZ4Aid/kz2h6yEY0axA909+VdDI6oMd2tS+CHcNHzA D0HkfEOBacuIUIVFmUIIHk/Jd16eJgZASavtjll2iB+lucMht9j3+MYlP2oIaMm3 DOo86z7OO+kCYo738mYGdAYn8J7oDTlMUUGpgP44O8bzZcVin5s= =RANj -----END PGP SIGNATURE----- --GR6CwbWmoWwTd7w4--