public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] test/lib/test: Clean up iperf3 JSON files before starting the server
Date: Thu, 17 Nov 2022 10:02:03 +1100	[thread overview]
Message-ID: <Y3Vr6yIzzTyuI6UJ@yekko> (raw)
In-Reply-To: <20221116135331.248003-1-sbrivio@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1478 bytes --]

On Wed, Nov 16, 2022 at 02:53:31PM +0100, Stefano Brivio wrote:
> ...instead of doing it after the test. Now that we have pre-built
> guest images, we might also have old JSON files from previous,
> interrupted test runs.
> 
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

Even better would be to put those in the STATEDIR, of course.

> ---
>  test/lib/test | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/test/lib/test b/test/lib/test
> index df32178..29612c2 100755
> --- a/test/lib/test
> +++ b/test/lib/test
> @@ -31,6 +31,8 @@ test_iperf3() {
>  	__procs="$((${1} - 1))"; shift
>  	__time="${1}"; shift
>  
> +	pane_or_context_run "${__sctx}" 'rm -f s*.json'
> +
>  	pane_or_context_run_bg "${__sctx}" 				\
>  		 'for i in $(seq 0 '${__procs}'); do'			\
>  		 '	(iperf3 -s1J -p'${__port}' -i'${__time}		\
> @@ -64,8 +66,6 @@ test_iperf3() {
>  
>  	__bw=$(pane_or_context_output "${__sctx}"			\
>  		 'cat s*.json | jq -rMs "map('${__jval}') | add"')
> -	pane_or_context_run "${__sctx}"					\
> -		'for i in $(seq 0 '${__procs}'); do rm s${i}.json; done'
>  
>  	TEST_ONE_subs="$(list_add_pair "${TEST_ONE_subs}" "__${__var}__" "${__bw}" )"
>  

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2022-11-16 23:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16 13:53 [PATCH] test/lib/test: Clean up iperf3 JSON files before starting the server Stefano Brivio
2022-11-16 23:02 ` David Gibson [this message]
2022-11-17  7:25   ` Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y3Vr6yIzzTyuI6UJ@yekko \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).