From: David Gibson <david@gibson.dropbear.id.au>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: sbrivio@redhat.com, passt-dev@passt.top
Subject: Re: [PATCH passt v2 1/7] build: Force-create pasta symlink
Date: Fri, 18 Nov 2022 12:30:25 +1100 [thread overview]
Message-ID: <Y3bgMcH6DIxnvi5c@yekko> (raw)
In-Reply-To: <20221117184938.2270462-2-rjones@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]
On Thu, Nov 17, 2022 at 06:49:32PM +0000, Richard W.M. Jones wrote:
> If you run the build several times it will fail unnecessarily with:
>
> ln -s passt pasta
> ln: failed to create symbolic link 'pasta': File exists
> make: *** [Makefile:134: pasta] Error 1
>
> Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
I'm not sure why I haven't hit that before.
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 1dc2df5..f8ecaea 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -133,7 +133,7 @@ passt.avx2: $(PASST_SRCS) $(HEADERS)
> passt.avx2: passt
>
> pasta.avx2 pasta.1 pasta: pasta%: passt%
> - ln -s $< $@
> + ln -sf $< $@
>
> qrap: $(QRAP_SRCS) passt.h
> $(CC) $(FLAGS) $(CFLAGS) $(CPPFLAGS) $(QRAP_SRCS) -o qrap $(LDFLAGS)
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-11-18 4:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 18:49 [PATCH passt v2 0/7] Add fuzzing Richard W.M. Jones
2022-11-17 18:49 ` [PATCH passt v2 1/7] build: Force-create pasta symlink Richard W.M. Jones
2022-11-18 1:30 ` David Gibson [this message]
2022-11-18 7:56 ` Stefano Brivio
2022-11-17 18:49 ` [PATCH passt v2 2/7] build: Remove *~ files with make clean Richard W.M. Jones
2022-11-18 1:31 ` David Gibson
2022-11-17 18:49 ` [PATCH passt v2 3/7] passt, tap: Add --fd option Richard W.M. Jones
2022-11-17 18:49 ` [PATCH passt v2 4/7] passt, tap: Process data on the socket before HUP/ERR events Richard W.M. Jones
2022-11-18 1:32 ` David Gibson
2022-11-17 18:49 ` [PATCH passt v2 5/7] XXX build: Add extra syscalls needed by AFL instrumentation Richard W.M. Jones
2022-11-17 18:49 ` [PATCH passt v2 6/7] XXX passt: Kill seccomp and other isolation mechanisms Richard W.M. Jones
2022-11-17 18:49 ` [PATCH passt v2 7/7] Import fuzzing wrapper from libnbd Richard W.M. Jones
2022-11-17 19:06 ` [PATCH passt v2 0/7] Add fuzzing Richard W.M. Jones
2022-11-18 10:12 ` Richard W.M. Jones
2022-11-25 9:23 ` Stefano Brivio
2022-11-25 10:11 ` Richard W.M. Jones
2022-11-29 13:34 ` Stefano Brivio
2022-11-29 13:44 ` Richard W.M. Jones
2022-11-30 1:11 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3bgMcH6DIxnvi5c@yekko \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=rjones@redhat.com \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).