From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 446C75A026A for ; Fri, 18 Nov 2022 05:59:25 +0100 (CET) Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4ND4MC0wnLz4xZ3; Fri, 18 Nov 2022 15:59:19 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1668747559; bh=4d3ipy6Tr0eHBN5ALWiCPp5IofjOHDiFXDoT69ase2M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SGX0tJGbIt2JUTjp/e2yN5RFYAJ/pUo8OXUurLrcilIxjF0FNrpqt/0kvhbBoj/tf Q4ICJ8kgKIKUDCDxdNXqUI8CQOQQXtDcw9VnzZN08fQZVEsDdTv9C7hJ1jgmaxDENt kwixM0zp0uBwD5u0YzhLVXS6mebU61wRWEeQo7ZQ= Date: Fri, 18 Nov 2022 12:30:25 +1100 From: David Gibson To: "Richard W.M. Jones" Subject: Re: [PATCH passt v2 1/7] build: Force-create pasta symlink Message-ID: References: <20221117184938.2270462-1-rjones@redhat.com> <20221117184938.2270462-2-rjones@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qyipxvhZzCAnnlGj" Content-Disposition: inline In-Reply-To: <20221117184938.2270462-2-rjones@redhat.com> Message-ID-Hash: RQR2RD5YBDE3XCFDVDQXZMCCI6UDXWTD X-Message-ID-Hash: RQR2RD5YBDE3XCFDVDQXZMCCI6UDXWTD X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: sbrivio@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --qyipxvhZzCAnnlGj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 17, 2022 at 06:49:32PM +0000, Richard W.M. Jones wrote: > If you run the build several times it will fail unnecessarily with: >=20 > ln -s passt pasta > ln: failed to create symbolic link 'pasta': File exists > make: *** [Makefile:134: pasta] Error 1 >=20 > Signed-off-by: Richard W.M. Jones Reviewed-by: David Gibson I'm not sure why I haven't hit that before. > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/Makefile b/Makefile > index 1dc2df5..f8ecaea 100644 > --- a/Makefile > +++ b/Makefile > @@ -133,7 +133,7 @@ passt.avx2: $(PASST_SRCS) $(HEADERS) > passt.avx2: passt > =20 > pasta.avx2 pasta.1 pasta: pasta%: passt% > - ln -s $< $@ > + ln -sf $< $@ > =20 > qrap: $(QRAP_SRCS) passt.h > $(CC) $(FLAGS) $(CFLAGS) $(CPPFLAGS) $(QRAP_SRCS) -o qrap $(LDFLAGS) --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --qyipxvhZzCAnnlGj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoULxWu4/Ws0dB+XtgypY4gEwYSIFAmN24CsACgkQgypY4gEw YSL/vg/8CHtgVFOIZuAaWiX25ZhVW55v/kIyj1ZWyOTFpOpzo8qsSaXaonHSxAYM R1RSe101hQiK4Sqqs27NQg2Vz6WQPodMLGyOCx8RSX0LKx3ejZG8xxVdTZ7S3EwX zeST3UkLtjCTXBx5HaAT+gkqiEnFCPOLNP+OcEF0ESNfdIShu0UehP6lNZ4Vp2vK a92epwkgD7OBc4/jwN/q7XyjiL7hVGbpnb2oQy5y6f+fQUcqqq8ygA0pcn5HhBUN XLTHFjIDhLHvJ6q2d+MQiqdkETeCVcfOJunqfYNa7CGwanPzmWUEiSk/UxCUbr+l jM+M/tPJrZ6xdOI0/4SFjQ6Vk+wbgyPtXf8469kPnYP63cLmkgvJZ7PREpc9pfs2 V2kr5AFufjOSOQytVHua8my7UnPCYipQv6YZ6pYEwzGMi4F1Z3/AKoXpzkX4yYSE p1vykw20cggSs7U+ImpEzcaQY7h2RqkF7tl/WB90Jr67ZeopmucO8o8Gbu9p4lN3 GE+aD4TDuYcYWJqFUJYejacGA8NuCwkRZX830a+UqrMAYKerCDe0DU8jrSX74tKL ADrlaZmFrw05KQC64GhQPWud1Yk03/59/KyYumbKnuXvwRJOJTiDyXqQeWw3Doio qESf0fbLQ8X0arY1Q+gUsQ9GkKCJ99lhKr32LjN17eY7JclKvms= =fLwX -----END PGP SIGNATURE----- --qyipxvhZzCAnnlGj--