From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v2 09/16] udp: Don't explicitly track originating socket for spliced "connections"
Date: Fri, 25 Nov 2022 18:09:05 +1100 [thread overview]
Message-ID: <Y4BqEcpsi2YcSkD4@yekko> (raw)
In-Reply-To: <20221125024805.3c95793d@elisabeth>
[-- Attachment #1: Type: text/plain, Size: 1253 bytes --]
On Fri, Nov 25, 2022 at 02:48:05AM +0100, Stefano Brivio wrote:
> Nit:
>
> On Thu, 24 Nov 2022 12:16:52 +1100
> David Gibson <david@gibson.dropbear.id.au> wrote:
>
> > When we look up udp_splice_to_ns[][].orig_sock in udp_sock_handler_splice()
> > we're finding the socket on which the originating packet for the
> > "connection" was received on. However, we don't specifically need this
> > socket to be the originating one - we just need one that's bound to the
> > the source port of this reply packet in the init namespace. We can look
> > this up in udp_splice_to_init[v6][src].target_sock, whose defining
> > characteristic is exactly that. The same applies with init and ns swapped.
> >
> > In practice, of course, the port we locate this way will always be the
> > originating port, since we couldn't have started this "connection" if it
> > wasn't.
> >
> > Change this, and we no longer need the @orig_sock field at all. That leaves just @target_sock which we rename to simply @sock. The
>
> Long line here.
Fixed.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-11-25 7:17 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 1:16 [PATCH v2 00/16] Simplify and correct handling of "spliced" UDP forwarding David Gibson
2022-11-24 1:16 ` [PATCH v2 01/16] udp: Also bind() connected ports for "splice" forwarding David Gibson
2022-11-25 1:47 ` Stefano Brivio
2022-11-25 7:01 ` David Gibson
2022-11-24 1:16 ` [PATCH v2 02/16] udp: Separate tracking of inbound and outbound packet flows David Gibson
2022-11-25 1:47 ` Stefano Brivio
2022-11-25 7:06 ` David Gibson
2022-11-24 1:16 ` [PATCH v2 03/16] udp: Always use sendto() rather than send() for forwarding spliced packets David Gibson
2022-11-24 1:16 ` [PATCH v2 04/16] udp: Don't connect "forward" sockets for spliced flows David Gibson
2022-11-25 1:47 ` Stefano Brivio
2022-11-25 7:07 ` David Gibson
2022-12-01 18:49 ` Stefano Brivio
2022-11-24 1:16 ` [PATCH v2 05/16] udp: Remove the @bound field from union udp_epoll_ref David Gibson
2022-11-24 1:16 ` [PATCH v2 06/16] udp: Split splice field in udp_epoll_ref into (mostly) independent bits David Gibson
2022-11-24 1:16 ` [PATCH v2 07/16] udp: Don't create double sockets for -U port David Gibson
2022-11-24 1:16 ` [PATCH v2 08/16] udp: Re-use fixed bound sockets for packet forwarding when possible David Gibson
2022-11-24 1:16 ` [PATCH v2 09/16] udp: Don't explicitly track originating socket for spliced "connections" David Gibson
2022-11-25 1:48 ` Stefano Brivio
2022-11-25 7:09 ` David Gibson [this message]
2022-11-24 1:16 ` [PATCH v2 10/16] udp: Update UDP "connection" timestamps in both directions David Gibson
2022-11-24 1:16 ` [PATCH v2 11/16] udp: Simplify udp_sock_handler_splice David Gibson
2022-11-24 1:16 ` [PATCH v2 12/16] udp: Make UDP_SPLICE_FRAMES and UDP_TAP_FRAMES_MEM the same thing David Gibson
2022-11-24 1:16 ` [PATCH v2 13/16] udp: Add helper to extract port from a sockaddr_in or sockaddr_in6 David Gibson
2022-11-25 1:48 ` Stefano Brivio
2022-11-25 7:10 ` David Gibson
2022-11-24 1:16 ` [PATCH v2 14/16] udp: Unify buffers for tap and splice paths David Gibson
2022-11-24 1:16 ` [PATCH v2 15/16] udp: Split send half of udp_sock_handler_splice() from the receive half David Gibson
2022-11-24 1:16 ` [PATCH v2 16/16] udp: Correct splice forwarding when receiving from multiple sources David Gibson
2022-11-29 5:55 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4BqEcpsi2YcSkD4@yekko \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).