On Fri, Nov 25, 2022 at 02:48:05AM +0100, Stefano Brivio wrote:
> Nit:
> 
> On Thu, 24 Nov 2022 12:16:52 +1100
> David Gibson <david@gibson.dropbear.id.au> wrote:
> 
> > When we look up udp_splice_to_ns[][].orig_sock in udp_sock_handler_splice()
> > we're finding the socket on which the originating packet for the
> > "connection" was received on.  However, we don't specifically need this
> > socket to be the originating one - we just need one that's bound to the
> > the source port of this reply packet in the init namespace.  We can look
> > this up in udp_splice_to_init[v6][src].target_sock, whose defining
> > characteristic is exactly that.  The same applies with init and ns swapped.
> > 
> > In practice, of course, the port we locate this way will always be the
> > originating port, since we couldn't have started this "connection" if it
> > wasn't.
> > 
> > Change this, and we no longer need the @orig_sock field at all. That leaves just @target_sock which we rename to simply @sock.  The
> 
> Long line here.

Fixed.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson