From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id BDC965A026A for ; Fri, 25 Nov 2022 08:17:26 +0100 (CET) Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4NJR5C6qTNz4xNB; Fri, 25 Nov 2022 18:17:19 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1669360639; bh=M6doD9irw4jkAjBAEAWHyhhvhTnAiu67cwYRmzasHvQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bhwH6clzTURzt6bO2Pa6w32tV8nB0Fi6yGfbAFxRfuV0CWsKG6SsQaBe8Oavw58G+ LkfgD6l9kzopiGMd3HnyNjji/Fk0ubACN8CMf3hbepnV0YVcMmh4SWdxi8LABT8BUb 6SSR8m7IKoBYGrg8Wlo0Fx7GIJI1jPtPR30LAdmE= Date: Fri, 25 Nov 2022 18:11:03 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 0/4] udp: Fix some confusion of IPv4 and IPv6 control structures Message-ID: References: <20221124085421.3027886-1-david@gibson.dropbear.id.au> <20221125030121.760ff153@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="N75Zptvsb3NjykOy" Content-Disposition: inline In-Reply-To: <20221125030121.760ff153@elisabeth> Message-ID-Hash: WWD5OHQKGYPWBJMFM3KBY6U6AXHOK6CI X-Message-ID-Hash: WWD5OHQKGYPWBJMFM3KBY6U6AXHOK6CI X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --N75Zptvsb3NjykOy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 25, 2022 at 03:01:21AM +0100, Stefano Brivio wrote: > On Thu, 24 Nov 2022 19:54:17 +1100 > David Gibson wrote: >=20 > > It turns out a couple of places on the IPv4 specific inbound path > > accidentally use control structures that are supposed to be for IPv6. > > That could lead to weird behaviour in a rather complex set of > > circumstances. >=20 > Whoops, this is embarrassing. Heh, been there. > > Path 1/4 here is the actual fix, the rest makes some clean ups to the > > code that should make similar mistakes harder errors harder to commit > > in future. >=20 > The whole series looks good to me. >=20 > > This is based on my earlier cleanup of the UDP splicing code, although > > I think it will rebase trivially. >=20 > I tried, it does, but I wouldn't needlessly rebase that one on top of > this, I'd rather wait a bit and apply them in order. Ok. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --N75Zptvsb3NjykOy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoULxWu4/Ws0dB+XtgypY4gEwYSIFAmOAaoAACgkQgypY4gEw YSIU+BAApqXyNI1O9PVeQurWGxu7Nk4QT9Flp/chpUtU55P5zk0hCu/yVxLNlANl SFZeH2T4d8aZKIb40leW9qFwNJON0WZV9wv80HsL++VpK4my3AKaRxyCfy9wMv0/ f+zLjzqByUFAVMsytCDEDMYkWkmUohlT65ryCM+Ca9AguqWep3UL5bhGxWwIbHLa x/J9wKzfWGIu+pCdK31y/2D+Of04RjFpWu66dz54YLVPIh5XGjkQi2aii9fTJ3et CBdczh5da3VhiAlmyGn/vMgbdbUFBzRVBwHafxO859A4/k8fDvsGSbJINf9/qk1D fSS8MGmgRd0CYwxbrLO1iKxXvk2wDI73/cP7koFY3nli5ILc+WAGtNjW09kbb4Sl tJqwxZzy+03rH6HXOGD2Nx5nTaKNhMZbxsLLdR3cTdJqJTpzEggUC8pF41fwcB3l 5vTWgPfvkjb205PuLO8SzD8pIgIqI+VFFRdKdsZAJb/O6cEmLxzDXN0wGgndHJ0e 3lOmYD0lTOxNLuZcj9CFeYS/UorTp9debg0HYS39HE3QNrCyLE+uHeic+wx+2uvt 4f+C/ci0U78/xqJDSny9opA1kN0deDt9cCws+jdNq4ama1Hx4i36Wn1/WBkkw3cw 3xLTKWJQM68VTDJ2UK82+UHOLMCdedzbG363n53pXoD8h8YAWEo= =8xAN -----END PGP SIGNATURE----- --N75Zptvsb3NjykOy--