From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124])
	by passt.top (Postfix) with ESMTP id 1A3B85A0082
	for <passt-dev@passt.top>; Wed, 11 Jan 2023 19:33:31 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1673462009;
	h=from:from:reply-to:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:in-reply-to:in-reply-to:  references:references;
	bh=ASyF6HYpLx1pjgeUkcqhvnIkTPZrrZt846o9XcNzSGE=;
	b=PVEh75mXQhi7kq1k0qeYQwOI29vfcnuwvPE//Iv1Ps1Zw7T3pwxL6cPCONcqSyFJz6RzQp
	8yOm8vZzLu393B0jYrZY/dUAGuOVxKSe+9YC1BlFsQ1I4BsNw4hcO28tv1+Iah1zyO3xKg
	bBo1vQ2SnoWdOMPcuv5IutX/g/kEmOA=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-558-uxkpLr6mPJKWCZCtSNVR5g-1; Wed, 11 Jan 2023 13:33:28 -0500
X-MC-Unique: uxkpLr6mPJKWCZCtSNVR5g-1
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C7C9A3C22745
	for <passt-dev@passt.top>; Wed, 11 Jan 2023 18:33:27 +0000 (UTC)
Received: from redhat.com (unknown [10.33.36.119])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 9D35440C1141;
	Wed, 11 Jan 2023 18:33:26 +0000 (UTC)
Date: Wed, 11 Jan 2023 18:33:23 +0000
From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= <berrange@redhat.com>
To: Laine Stump <laine@redhat.com>
Subject: Re: [libvirt PATCH 4/9] conf: add passt XML additions to schema
Message-ID: <Y78A80CQC6MLW3jw@redhat.com>
References: <20230109041112.368790-1-laine@redhat.com>
 <20230109041112.368790-5-laine@redhat.com>
MIME-Version: 1.0
In-Reply-To: <20230109041112.368790-5-laine@redhat.com>
User-Agent: Mutt/2.2.9 (2022-11-12)
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
X-MailFrom: berrange@redhat.com
X-Mailman-Rule-Hits: nonmember-moderation
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation
Message-ID-Hash: DQLMYH4GM53PYPHYPXDC263PNH3TIW32
X-Message-ID-Hash: DQLMYH4GM53PYPHYPXDC263PNH3TIW32
X-Mailman-Approved-At: Thu, 12 Jan 2023 14:00:24 +0100
CC: libvir-list@redhat.com, sbrivio@redhat.com, passt-dev@passt.top
X-Mailman-Version: 3.3.3
Precedence: list
Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= <berrange@redhat.com>
List-Id: Development discussion and patches for passt <passt-dev.passt.top>
Archived-At: <https://archives.passt.top/passt-dev/Y78A80CQC6MLW3jw@redhat.com/>
Archived-At: <https://passt.top/hyperkitty/list/passt-dev@passt.top/message/DQLMYH4GM53PYPHYPXDC263PNH3TIW32/>
List-Archive: <https://archives.passt.top/passt-dev/>
List-Archive: <https://passt.top/hyperkitty/list/passt-dev@passt.top/>
List-Help: <mailto:passt-dev-request@passt.top?subject=help>
List-Owner: <mailto:passt-dev-owner@passt.top>
List-Post: <mailto:passt-dev@passt.top>
List-Subscribe: <mailto:passt-dev-join@passt.top>
List-Unsubscribe: <mailto:passt-dev-leave@passt.top>

On Sun, Jan 08, 2023 at 11:11:07PM -0500, Laine Stump wrote:
> Initial support for network devices using passt (https://passt.top)
> for the backend connection will require:
> 
> * new attributes of the <backend> subelement:
>   * "type" that can have the value "passt" (to differentiate from
>     slirp, because both slirp and passt will use <interface
>     type='user'>)
>   * "logFile" (a path to a file that passt should use for its logging)
>   * "upstream" (a netdev name, e.g. "eth0").

IMHO this attribute is inappropriate for <backend>....

> * a new subelement <portForward> (described in more detail later)
> 
> Signed-off-by: Laine Stump <laine@redhat.com>
> ---
>  src/conf/schemas/domaincommon.rng         | 65 +++++++++++++++++++++++
>  tests/qemuxml2argvdata/net-user-passt.xml | 57 ++++++++++++++++++++
>  2 files changed, 122 insertions(+)
>  create mode 100644 tests/qemuxml2argvdata/net-user-passt.xml
> 
> diff --git a/tests/qemuxml2argvdata/net-user-passt.xml b/tests/qemuxml2argvdata/net-user-passt.xml
> new file mode 100644
> index 0000000000..b82eebd089
> --- /dev/null
> +++ b/tests/qemuxml2argvdata/net-user-passt.xml
> @@ -0,0 +1,57 @@
> +<domain type='qemu'>
> +  <name>QEMUGuest1</name>
> +  <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
> +  <memory unit='KiB'>219136</memory>
> +  <currentMemory unit='KiB'>219136</currentMemory>
> +  <vcpu placement='static'>1</vcpu>
> +  <os>
> +    <type arch='x86_64' machine='pc'>hvm</type>
> +    <boot dev='hd'/>
> +  </os>
> +  <clock offset='utc'/>
> +  <on_poweroff>destroy</on_poweroff>
> +  <on_reboot>restart</on_reboot>
> +  <on_crash>destroy</on_crash>
> +  <devices>
> +    <emulator>/usr/bin/qemu-system-x86_64</emulator>
> +    <disk type='block' device='disk'>
> +      <driver name='qemu' type='raw'/>
> +      <source dev='/dev/HostVG/QEMUGuest1'/>
> +      <target dev='hda' bus='ide'/>
> +      <address type='drive' controller='0' bus='0' target='0' unit='0'/>
> +    </disk>
> +    <controller type='usb' index='0' model='none'/>
> +    <controller type='ide' index='0'>
> +      <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/>
> +    </controller>
> +    <controller type='pci' index='0' model='pci-root'/>
> +    <interface type='user'>
> +      <mac address='00:11:22:33:44:55'/>
> +      <ip address='172.17.2.0' family='ipv4' prefix='24'/>
> +      <ip address='2001:db8:ac10:fd01::feed' family='ipv6'/>
> +      <portForward proto='tcp' address='2001:db8:ac10:fd01::1:10'>
> +        <range start='22' to='2022'/>
> +        <range start='1000' end='1050'/>
> +        <range start='1020' exclude='yes'/>
> +        <range start='1030' end='1040' exclude='yes'/>
> +      </portForward>
> +      <portForward proto='udp' address='1.2.3.4' dev='eth0'>
> +        <range start='5000' end='5020' to='6000'/>
> +        <range start='5010' end='5015' exclude='yes'/>
> +      </portForward>
> +      <portForward proto='tcp'>
> +        <range start='80'/>
> +      </portForward>
> +      <portForward proto='tcp'>
> +        <range start='443' to='344'/>
> +      </portForward>
> +      <model type='rtl8139'/>
> +      <backend type='passt' logFile='/var/log/loglaw.blog' upstream='eth42'/>

I don't think that 'upstream' is really describing a property of the
backend.

This is expressing a traffic routing restriction for the 'user'
networking type. IMHO it should probably be using the existing
<source dev="xxxx"/> element, that is currently used by the
'direct' networking type.

Can we see about fixing this before release.

> +      <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/>
> +    </interface>
> +    <input type='mouse' bus='ps2'/>
> +    <input type='keyboard' bus='ps2'/>
> +    <audio id='1' type='none'/>
> +    <memballoon model='none'/>
> +  </devices>
> +</domain>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|