From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id E404E5A0082 for ; Fri, 6 Jan 2023 01:59:31 +0100 (CET) Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Np4js6vcbz4y0k; Fri, 6 Jan 2023 11:59:29 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1672966769; bh=d7knCuCWVhTHsMIHP5ekrA6iELoaXSrLtH4H+hgxeHs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SYhvmc7mNhiV0N+2IGvf8XzEL6SGeU9ob/Vomq4J/HJFwy8sjVhQqkrZxJiPQU+0H t4d/V2HYYluKVYzn+NNmJajaZn5Bw6qIYItW/yPv17bC1OIxuH4rQOsCOpAnscB8WS HYhwiqLNb8sCdaSXBHi8Jj9D3ZxO8JqFLv+2sYh0= Date: Fri, 6 Jan 2023 11:59:11 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v4 0/8] Don't use additional sockets for receiving "spliced" UDP communications Message-ID: References: <20230105042625.1981812-1-david@gibson.dropbear.id.au> <20230105225003.023e4e66@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ShmvJdSPqkMMsO/V" Content-Disposition: inline In-Reply-To: <20230105225003.023e4e66@elisabeth> Message-ID-Hash: GTIE5QZEMLOYXCLO2UZ67S5ATN53VIJB X-Message-ID-Hash: GTIE5QZEMLOYXCLO2UZ67S5ATN53VIJB X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --ShmvJdSPqkMMsO/V Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 05, 2023 at 10:50:03PM +0100, Stefano Brivio wrote: > On Thu, 5 Jan 2023 15:26:17 +1100 > David Gibson wrote: >=20 > > At present, the UDP "splice" and "tap" paths are quite separate. We > > have separate sockets to receive packets bound for the tap and splice > > paths. This leads to some code duplication, and extra open sockets. > >=20 > > This series partially unifies the two paths, allowing us to use a > > single (host side) socket, bound to 0.0.0.0 or :: to receive packets > > for both cases. > >=20 > > Changes since v3: > > * Fixed really dumb compile error, and actually ran through the tests. > > Oops. > > Changes since v2: > > * Don't receive multiple packets at once for pasta mode - seems to > > hurt throughput on balance. > > * Add some comments clarifying reasoning here. > > Changes since v1: > > * Renamed udp_localname[46] to udp[46]_localname > > * Allow handling of UDP port 0 > > * Fix a bug which could misidentify certain v6 packets as v4-spliceable > > * Some minor cosmetic fixes to code and commit messages >=20 > Thanks, this looks good to me now, and I'm trying to run the tests > before applying it, but for some reason they get invariably stuck at > perf/passt_udp in the host to guest throughput test. >=20 > I think it has nothing to do with this series, and it's rather related > to the "new" suspected virtio-net TX timeout issue we started hitting a > while ago, I still need to play with kernel version/workarounds etc. > I'll keep you posted. Ah, right. I think I hit a similar issue with tx timeouts showing up. I think I just retried and it managed to get through on the 3rd or fourth attempt :/. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --ShmvJdSPqkMMsO/V Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoULxWu4/Ws0dB+XtgypY4gEwYSIFAmO3ckIACgkQgypY4gEw YSIWNg/+M0Pp76ques4SaBgIB+K3qz2yHHkQ5l+dpjAfOyiyfrds6lVRepi/7//L eMkQKDTkjbBDuYLA4Ausn7gx07oN3fYU15AGTh1Yq2XmJ0QivRKF3KMMyuscx8oa +BrVoxTlQFkK6M8QugyA1btWt7uJdsY4lz1F3b2XyKyymbgvHok9WLdy9agWG1Oa wBOoHsWvZ1MhzrX5L6OD8OSPx1vvgRE/hAVjI1uVzgk1bfgNzYEpCV9wzbI4pP6T cMlDDVlLD5+slcFGTaN17Kpg7v85/AoNLlyLmkqaBUG2Ap52El0h0q+ecE8X9y2e JUg1K8Wqo+coMyrJZ9Aq2azKbif9Ai+8Ht9OWJaNK8gaHw6Ns6qoiVun5XljlSda CPRQxh5G0yY+989FDOS13yDVYJzXAtGsaliWDNSdIbHC4YMOfu+QeOY1kFhdv7Lv 9BKYNkDOWaI/buAOEed+P8tGYd7WlNW+bQ0h9HKHghL8xC2lgH/441IvvuRBNmI+ H10kxPLhhem2naf4nH21ODoc6pxwOjmI0Yl+YrbumyA+Zutbi3FoxlhTaRjokyLq wvs5WCzyQ+nHX+VQ+3PTPmkgy/VKznMSmfTYEmU2oMCPsjFKNPZMlNfCZ9EcqxYX uuyfD0oNd89hdKi6vjVZgLDX7srDY6JEqsawsPgd/Hlmm3llcC8= =ZLE0 -----END PGP SIGNATURE----- --ShmvJdSPqkMMsO/V--