Re: [PATCH] Correct port ranges in --tcp-ports examples

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 2186 bytes --]

On Fri, Jan 06, 2023 at 03:08:36PM -0500, Laine Stump wrote:
> The proper syntax is:
> 
>    ${start}-${end}:${dststart}-${dstend}
> 
> not
> 
>    ${start}-${end}-${dststart}:${dstend}
> 
> Signed-off-by: Laine Stump <laine@redhat.com>
> ---
>  passt.1 | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/passt.1 b/passt.1
> index 528763b..0dad878 100644
> --- a/passt.1
> +++ b/passt.1
> @@ -349,7 +349,7 @@ Forward local ports 22 and 25 to ports 22 and 25 on the guest
>  -t 22-80
>  Forward local ports 22 to 80 to corresponding ports on the guest
>  .TP
> --t 22-80-32:90
> +-t 22-80:32-90
>  Forward local ports 22 to 80 to corresponding ports on the guest plus 10
>  .TP
>  -t 192.0.2.1/22
> @@ -361,7 +361,7 @@ Forward local port 22, bound to 192.0.2.1 and interface eth0, to port 22
>  -t 2000-5000,~3000-3010
>  Forward local ports 2000 to 5000, but not 3000 to 3010
>  .TP
> --t 192.0.2.1/20-30,~25
> +-t 192.0.2.1/20-26:24-30,~25-29
>  Forward local ports 20 to 24, and 26 to 30, bound to 192.0.2.1
>  .TP
>  -t ~20000-20010
> @@ -427,7 +427,7 @@ Forward local ports 22 and 25 to ports 22 and 25 in the target namespace
>  -t 22-80
>  Forward local ports 22 to 80 to corresponding ports in the target namespace
>  .TP
> --t 22-80-32:90
> +-t 22-80:32-90

Fixes above all look good.

>  Forward local ports 22 to 80 to corresponding ports plus 10 in the target
>  namespace
>  .TP
> @@ -440,7 +440,7 @@ Forward local port 22, bound to 192.0.2.1 and interface eth0, to port 22
>  -t 2000-5000,~3000-3010
>  Forward local ports 2000 to 5000, but not 3000 to 3010
>  .TP
> --t 192.0.2.1/20-30,~25
> +-t 192.0.2.1/20-26:24-30,~25-29

This one doesn't look like it's saying the same thing any more.  In
fact, this one doesn't list destination side ports at all, so I don't
think it needs to change.

>  Forward local ports 20 to 24, and 26 to 30, bound to 192.0.2.1
>  .TP
>  -t ~20000-20010

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]