From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id CDC065A005E for ; Mon, 9 Jan 2023 04:29:56 +0100 (CET) Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Nqzvy6qH3z4xGM; Mon, 9 Jan 2023 14:29:50 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1673234990; bh=jmLzc94tvWLPVLrwWYc7PP8n35ELf8C7U+Q83nrP9zk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iuzvgtPQMTQF8z0GVRI8iRXgP+R0r1xsY5iMY6GnJIRPBXpfaOp+CpkZOiGoPzDyI K1YNQI+Ycnlla7sI273JsvVeJxVqjCTpfYY16hdVFRG6wyQ8TITYvR9wa7xOAkGmCp qwCG/ecV0gKy+1rbgMOMM/d0IjvCQ7VLyODGJM5M= Date: Mon, 9 Jan 2023 13:33:01 +1100 From: David Gibson To: Laine Stump Subject: Re: [PATCH] Correct port ranges in --tcp-ports examples Message-ID: References: <20230106200836.117368-1-laine@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JEgPO5wCVJ6ldyrc" Content-Disposition: inline In-Reply-To: <20230106200836.117368-1-laine@redhat.com> Message-ID-Hash: FUDCPHGL42H4L2WHPNTDZLNODVCTRJ7K X-Message-ID-Hash: FUDCPHGL42H4L2WHPNTDZLNODVCTRJ7K X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --JEgPO5wCVJ6ldyrc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 06, 2023 at 03:08:36PM -0500, Laine Stump wrote: > The proper syntax is: >=20 > ${start}-${end}:${dststart}-${dstend} >=20 > not >=20 > ${start}-${end}-${dststart}:${dstend} >=20 > Signed-off-by: Laine Stump > --- > passt.1 | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/passt.1 b/passt.1 > index 528763b..0dad878 100644 > --- a/passt.1 > +++ b/passt.1 > @@ -349,7 +349,7 @@ Forward local ports 22 and 25 to ports 22 and 25 on t= he guest > -t 22-80 > Forward local ports 22 to 80 to corresponding ports on the guest > .TP > --t 22-80-32:90 > +-t 22-80:32-90 > Forward local ports 22 to 80 to corresponding ports on the guest plus 10 > .TP > -t 192.0.2.1/22 > @@ -361,7 +361,7 @@ Forward local port 22, bound to 192.0.2.1 and interfa= ce eth0, to port 22 > -t 2000-5000,~3000-3010 > Forward local ports 2000 to 5000, but not 3000 to 3010 > .TP > --t 192.0.2.1/20-30,~25 > +-t 192.0.2.1/20-26:24-30,~25-29 > Forward local ports 20 to 24, and 26 to 30, bound to 192.0.2.1 > .TP > -t ~20000-20010 > @@ -427,7 +427,7 @@ Forward local ports 22 and 25 to ports 22 and 25 in t= he target namespace > -t 22-80 > Forward local ports 22 to 80 to corresponding ports in the target namesp= ace > .TP > --t 22-80-32:90 > +-t 22-80:32-90 Fixes above all look good. > Forward local ports 22 to 80 to corresponding ports plus 10 in the target > namespace > .TP > @@ -440,7 +440,7 @@ Forward local port 22, bound to 192.0.2.1 and interfa= ce eth0, to port 22 > -t 2000-5000,~3000-3010 > Forward local ports 2000 to 5000, but not 3000 to 3010 > .TP > --t 192.0.2.1/20-30,~25 > +-t 192.0.2.1/20-26:24-30,~25-29 This one doesn't look like it's saying the same thing any more. In fact, this one doesn't list destination side ports at all, so I don't think it needs to change. > Forward local ports 20 to 24, and 26 to 30, bound to 192.0.2.1 > .TP > -t ~20000-20010 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --JEgPO5wCVJ6ldyrc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoULxWu4/Ws0dB+XtgypY4gEwYSIFAmO7fMEACgkQgypY4gEw YSLMiQ//VuM75JuL/YBC1BBthZK8gs4i8X4y9YykCmyurbL5vW/tIne6wCh/WmTy pgBH4gN4fdhGRNIVRXy31o6DJzvVsycLaHmytFZY7eqvX5mIWHcq1ivYN8mpRrjs E1agZtlbR5q6GOLNV42GbH61jc5KOQ89Ky8Ku20heLCQTFWurJBu1w5lSpK/31cr rPKWdpsV0h+avoTS6pYdkpX4usVfxgxMQSCoSKXZmEW4p1Q8HORl7/Pz2PrRSwPA hVeGFLl2oZxm1dEb7BovRZwLtamUUppwL9zeDjuXOA5r1BAluDW9ar1i31m+KQuD QU0Zi32lzag5o97bPTBq2XSqrJG95j33OwPG3fEfFbhpWMzonOjK/LHRUotw3ixf O6nW4oLVumooOCiU9vDK+ppYP6RnbHBNIff4Pxd1m2225dRbNhD4lQg2fVfSHY1g /IuyzCu2DRur2Wb3ULAj4mse8Yse4NFUOGvO1m4YMus4IurvLdUtQbHdsnHfXPxX 2CSd/mS3/GHDe4f/3amTIQOgfbObHhRty/eb5Z7LEQ+sCj8hQD/6OkMGA8GAZ+pJ gAYIgByYvHxM431Iq5K5ClX9WkTL+A8AW7B8kKZc4kBuhjDNxqJhYREiA82SV26n AxahcXrf6EzpUdieHy6qoAGE91Vb6AX3llxN8pAsz33q9cVZ/XY= =7j2Y -----END PGP SIGNATURE----- --JEgPO5wCVJ6ldyrc--