From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id E92E65A0082 for ; Mon, 9 Jan 2023 07:40:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673246430; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/jCO+suOvu5aQMeLsLu6ioCX7kj7fMlQ01relFnKRkE=; b=ci5JCBUPAbNpR9T2SGx03y74vF7WgLg0IE15Xd816xBkZFSGSF8fkNIXOPv8ptxyiGqC1W /EdYeiTRzrx3+Pi5NJMHBzicLYSgbxECvfS7HpZlIOJyMtau280KDRO/+b9Zy4+5Lr6tWd mXBNWZwF4WOrnOUTnf1ZaAGMaYu5or8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-561-sGpetV7WMRGru9JDb6uh-Q-1; Mon, 09 Jan 2023 01:40:28 -0500 X-MC-Unique: sGpetV7WMRGru9JDb6uh-Q-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0D85985A588 for ; Mon, 9 Jan 2023 06:40:28 +0000 (UTC) Received: from fedora (ovpn-192-19.brq.redhat.com [10.40.192.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CB5682166B26; Mon, 9 Jan 2023 06:40:26 +0000 (UTC) From: =?iso-8859-1?B?SuFu?= Tomko To: Laine Stump Subject: Re: [libvirt PATCH 1/9] conf: rename virDomainNetBackend* to virDomainNetDriver* Message-ID: References: <20230109041112.368790-1-laine@redhat.com> <20230109041112.368790-2-laine@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZMZXmqyKJ/A2Sd/a" Content-Disposition: inline In-Reply-To: <20230109041112.368790-2-laine@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation Message-ID-Hash: UGYLH6RQUV4HLYTORWPX3Z4EFO2V224I X-Message-ID-Hash: UGYLH6RQUV4HLYTORWPX3Z4EFO2V224I X-Mailman-Approved-At: Tue, 10 Jan 2023 16:08:41 +0100 CC: libvir-list@redhat.com, sbrivio@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Date: Mon, 09 Jan 2023 06:40:31 X-Original-Date: Mon, 9 Jan 2023 07:40:48 +0100 --ZMZXmqyKJ/A2Sd/a Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On a Sunday in 2023, Laine Stump wrote: >This fits better with the element containing the value (), and >allows us to use virDomainNetBackend* for things in the >element. > >Signed-off-by: Laine Stump >--- > src/conf/domain_conf.c | 8 ++++---- > src/conf/domain_conf.h | 14 +++++++------- > src/qemu/qemu_interface.c | 8 ++++---- > src/security/virt-aa-helper.c | 2 +- > 4 files changed, 16 insertions(+), 16 deletions(-) > >diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h >index c19dfc5470..61d2ee819b 100644 >--- a/src/conf/domain_conf.h >+++ b/src/conf/domain_conf.h >@@ -975,12 +975,12 @@ typedef enum { > > /* the backend driver used for virtio interfaces */ > typedef enum { >- VIR_DOMAIN_NET_BACKEND_TYPE_DEFAULT =3D 0, /* prefer kernel, fall bac= k to user */ >- VIR_DOMAIN_NET_BACKEND_TYPE_QEMU, /* userland */ >- VIR_DOMAIN_NET_BACKEND_TYPE_VHOST, /* kernel */ >+ VIR_DOMAIN_NET_DRIVER_TYPE_DEFAULT =3D 0, /* prefer kernel, fall back= to user */ >+ VIR_DOMAIN_NET_DRIVER_TYPE_QEMU, /* userland */ >+ VIR_DOMAIN_NET_DRIVER_TYPE_VHOST, /* kernel */ > >- VIR_DOMAIN_NET_BACKEND_TYPE_LAST >-} virDomainNetBackendType; >+ VIR_DOMAIN_NET_DRIVER_TYPE_LAST >+} virDomainNetDriverType; > > /* the TX algorithm used for virtio interfaces */ > typedef enum { >@@ -1062,7 +1062,7 @@ struct _virDomainNetDef { > char *modelstr; > union { > struct { >- virDomainNetBackendType name; /* which driver backend to use = */ >+ virDomainNetDriverType name; /* which driver backend to use */ I recommend geting rid of the mention of 'backend' by dropping the useless comment. > virDomainNetVirtioTxModeType txmode; > virTristateSwitch ioeventfd; > virTristateSwitch event_idx; Reviewed-by: J=E1n Tomko Jano --ZMZXmqyKJ/A2Sd/a Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQT+Rn5j0qdK2hQgnuAU0rOr/y4PvAUCY7u26AAKCRAU0rOr/y4P vAbTAQD3C7SUJDEm2NCrRLXy3sv/NOoskfCFAT1yoRmIJ0j/fgD+OWu/ryyeMXAh d0J2HNjo+VZJnkjKYw0R5Lzx4QqRFgQ= =8vLZ -----END PGP SIGNATURE----- --ZMZXmqyKJ/A2Sd/a--