From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 1C34C5A0082 for ; Mon, 9 Jan 2023 08:23:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673249012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4Pb86tI54kWV9aL/msxuH15m0ldPgIs8baAXUd+bDJ8=; b=ge6LFRhVmcrXXR1bR+3eIW3bdNPxh7KyQ3+XEG5yRG8l/XeLW48jpXDDoCAdD9Rbsze+3y 6r/GtX1TIMKyneOW1iLqJpvRgPgoCylf+Dx20aENabzGX2F0XB/yxW5Dcd8Bf7me1SwKGk 4AOVd85IkMLCOiCMpzeSG1usg/3c6FA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-399-Y76W4PbENd-S1-bLMQB2Yw-1; Mon, 09 Jan 2023 02:23:24 -0500 X-MC-Unique: Y76W4PbENd-S1-bLMQB2Yw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A111F38107E9 for ; Mon, 9 Jan 2023 07:23:24 +0000 (UTC) Received: from fedora (ovpn-192-19.brq.redhat.com [10.40.192.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 70317140EBF4; Mon, 9 Jan 2023 07:23:23 +0000 (UTC) From: =?iso-8859-1?B?SuFu?= Tomko To: Laine Stump Subject: Re: [libvirt PATCH 7/9] qemu: add passtStateDir to qemu driver config Message-ID: References: <20230109041112.368790-1-laine@redhat.com> <20230109041112.368790-8-laine@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0YdDKIiQSINYFQ8x" Content-Disposition: inline In-Reply-To: <20230109041112.368790-8-laine@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation Message-ID-Hash: B5SRAVXXDBL54SODXPLSRDMMJERCP77N X-Message-ID-Hash: B5SRAVXXDBL54SODXPLSRDMMJERCP77N X-Mailman-Approved-At: Tue, 10 Jan 2023 16:08:41 +0100 CC: libvir-list@redhat.com, sbrivio@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Date: Mon, 09 Jan 2023 07:23:33 X-Original-Date: Mon, 9 Jan 2023 08:23:45 +0100 --0YdDKIiQSINYFQ8x Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On a Sunday in 2023, Laine Stump wrote: >-- > >It seems a bit wasteful to allocate another string for this, since >it is 100% always ${stateDir}/passt, but everyone else is doing this >(e.g. slirpStateDir), so I'm just following along with the cult. > Did you mean to mark this as a note under '---'? >Signed-off-by: Laine Stump >--- > src/qemu/qemu_conf.c | 2 ++ > src/qemu/qemu_conf.h | 1 + > src/qemu/qemu_driver.c | 12 ++++++++++++ > 3 files changed, 15 insertions(+) Either way: Reviewed-by: J=E1n Tomko Jano --0YdDKIiQSINYFQ8x Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHQEARYKAB0WIQT+Rn5j0qdK2hQgnuAU0rOr/y4PvAUCY7vBAAAKCRAU0rOr/y4P vGz9APjgbS/ljuJ8lC7prHyYQghrtMHQq4cBCInu0nTurZp1AP9yLA8g451FTMqd fmNuzQpRsZIx/LxYk5k7OSZS1FcsDg== =AVaO -----END PGP SIGNATURE----- --0YdDKIiQSINYFQ8x--