From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id DFECB5A0082 for ; Mon, 9 Jan 2023 08:32:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673249558; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KURWeqRJIGE25DT8FgFl3XNyI8DuiKTjP87V4FgrFiQ=; b=ar60sALtU35A2aDgFfDoINj4ur00noXNDA/4M47FvIRp7+fr0hWYZMu+4RAaxT9/+q7llP frnRLBqVymwiBv6sazs5piB2QkZw2lyXTxxAVCLdg1XXndswtcMUX7VGJkASsXvV5doKJT kJY+0N3ZEQJ1eyd1zwogQRHgJ8z5Q28= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-632-NrWncXGUOCqqvrydC2SWkw-1; Mon, 09 Jan 2023 02:32:34 -0500 X-MC-Unique: NrWncXGUOCqqvrydC2SWkw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DFB60886C7B for ; Mon, 9 Jan 2023 07:32:32 +0000 (UTC) Received: from fedora (ovpn-192-19.brq.redhat.com [10.40.192.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E308B492B01; Mon, 9 Jan 2023 07:32:31 +0000 (UTC) From: =?iso-8859-1?B?SuFu?= Tomko To: Laine Stump Subject: Re: [libvirt PATCH 9/9] specfile: require passt for the build if fedora >= 36 or rhel >= 9 Message-ID: References: <20230109041112.368790-1-laine@redhat.com> <20230109041112.368790-10-laine@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pAbJnVa8hKLPZeQU" Content-Disposition: inline In-Reply-To: <20230109041112.368790-10-laine@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-MailFrom: jtomko@redhat.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation Message-ID-Hash: D555MUT3GAWSSIG7KJQOMRNODE7AFOJV X-Message-ID-Hash: D555MUT3GAWSSIG7KJQOMRNODE7AFOJV X-Mailman-Approved-At: Tue, 10 Jan 2023 16:08:41 +0100 CC: libvir-list@redhat.com, sbrivio@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Date: Mon, 09 Jan 2023 07:32:39 X-Original-Date: Mon, 9 Jan 2023 08:32:53 +0100 --pAbJnVa8hKLPZeQU Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On a Sunday in 2023, Laine Stump wrote: >The only reason we need it at build time is to find its location in >$PATH so it can be hardcoded into the libvirt binary (and avoid the >possibility of someone adding in a malicious binary somewhere earlier >in the path, I guess). > >Only 'recommend' passt during installation though, since it is not >needed unless someone is actually using it. > >There is no need to add in a build-time "WITH_PASST" option (IMO), >since it adds very little to the size of the code - "PASST" (the path >to the binary) will just be set to "passt", so if someone does manage >to build and install passt on an older version of Fedora or RHEL, it >will still work (as long as it's installed somewhere in the path). > >Signed-off-by: Laine Stump >--- > libvirt.spec.in | 7 +++++++ > 1 file changed, 7 insertions(+) > Reviewed-by: J=E1n Tomko Jano --pAbJnVa8hKLPZeQU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQT+Rn5j0qdK2hQgnuAU0rOr/y4PvAUCY7vDJQAKCRAU0rOr/y4P vLonAPoDrUJ2r0GL8EAfSzbzNFslVjW/muV8kS/F0z2aKZMBvAEAtI6PERh8xDHS J2E1OclXtQH3EFDyvBkUvR07bcsYHAU= =7Yl+ -----END PGP SIGNATURE----- --pAbJnVa8hKLPZeQU--