From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 58AE65A005E for ; Thu, 12 Jan 2023 19:12:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673547157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wfoyQuzA/RDaG1NRDvlCnDuYZDsWyGdHVEQzWWklxjo=; b=RJRneVP4HsKC8CWYsYnO9VdcZChH/zFY8oGNclfz4hX16pCfjTxhSs7wqcgi+hEvEvUFer pfcFEFUIWrJe6FPkBPZ7mIJ3Df21jCIzi7jC2mkG6bVRQXeseU+ak62sOIV3X//HtvuIRN egrSM9c3nhpaT9x6bsAAzD3nV3uthMg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-626-1Yu7sLqLP-KXiKIFu1szFA-1; Thu, 12 Jan 2023 13:12:33 -0500 X-MC-Unique: 1Yu7sLqLP-KXiKIFu1szFA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E6F2B801779 for ; Thu, 12 Jan 2023 18:12:32 +0000 (UTC) Received: from rein (ovpn-192-107.brq.redhat.com [10.40.192.107]) by smtp.corp.redhat.com (Postfix) with ESMTP id A42174078903; Thu, 12 Jan 2023 18:12:32 +0000 (UTC) Date: Thu, 12 Jan 2023 19:12:29 +0100 From: Jiri Denemark To: Laine Stump Subject: Re: [libvirt PATCH 4/9] conf: add passt XML additions to schema Message-ID: References: <20230109041112.368790-1-laine@redhat.com> <20230109041112.368790-5-laine@redhat.com> <11955eac-2c40-7c21-2f15-91c4bdade4ed@redhat.com> MIME-Version: 1.0 In-Reply-To: <11955eac-2c40-7c21-2f15-91c4bdade4ed@redhat.com> User-Agent: Mutt/2.2.8 (2022-11-05) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable X-MailFrom: jdenemar@redhat.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation Message-ID-Hash: MSSK636IFVITZDRZXOBCD6TYNHFCSDAQ X-Message-ID-Hash: MSSK636IFVITZDRZXOBCD6TYNHFCSDAQ X-Mailman-Approved-At: Fri, 13 Jan 2023 15:43:12 +0100 CC: Libvirt , sbrivio@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.3 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, Jan 12, 2023 at 09:45:39 -0500, Laine Stump wrote: > On 1/11/23 1:33 PM, Daniel P. Berrang=E9 wrote: > > On Sun, Jan 08, 2023 at 11:11:07PM -0500, Laine Stump wrote: > >> + > >=20 > > I don't think that 'upstream' is really describing a property of the > > backend. > >=20 > > This is expressing a traffic routing restriction for the 'user' > > networking type. IMHO it should probably be using the existing > > element, that is currently used by the > > 'direct' networking type. >=20 > I'm still not sure *exactly* what it does; it apparently grabs the=20 > routes that are fed to the guest from the given host interface; I should = > probably ask Stefano to explain it to me again (he described it once,=20 > but that was along with explanations of several other things). >=20 > So it's not *exactly* the same as for type=3D'direc= t'=20 > (which determines the link-level connection rather than IP routing), but = > definitely very similar. >=20 >=20 > > Can we see about fixing this before release. >=20 > Yes, that makes sense. I'm not sure why I didn't think of it (usually I=20 > try *too* hard to re-use existing XML). >=20 > I'll make a patch and send it later today. Great, I'm waiting with tagging rc2 until this is done. Jirka