From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: Re: [PATCH 3/3] tests: Don't check exit code for every command in demo mode
Date: Thu, 19 May 2022 13:49:08 +1000 [thread overview]
Message-ID: <YoW+NBuHrB5dx/QB@yekko> (raw)
In-Reply-To: <20220518232829.2775820-4-sbrivio@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 861 bytes --]
On Thu, May 19, 2022 at 01:28:29AM +0200, Stefano Brivio wrote:
> Having all those 'echo $?' is rather distracting in demos.
>
> Signed-off-by: Sefano Brivio <sbrivio(a)redhat.com>
Reviewed-by: David Gibson <david(a)gibson.dropbear.id.au>
> ---
> test/lib/term | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/test/lib/term b/test/lib/term
> index 004c2a2..0f581de 100755
> --- a/test/lib/term
> +++ b/test/lib/term
> @@ -232,6 +232,9 @@ pane_parse() {
> # $1: Pane name
> pane_status() {
> pane_wait "${1}"
> +
> + [ ${DEMO} -eq 1 ] && return 0
> +
> __status="$(pane_parse "${1}")"
> while ! [ "${__status}" -eq "${__status}" ]; do
> sleep 1
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2022-05-19 3:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 23:28 [PATCH 0/3] tests: A few fixes for demos Stefano Brivio
2022-05-18 23:28 ` [PATCH 1/3] demo/pasta: Fix bad sleep directive Stefano Brivio
2022-05-19 3:48 ` David Gibson
2022-05-18 23:28 ` [PATCH 2/3] tests: Don't count number of test units for demos Stefano Brivio
2022-05-19 3:48 ` David Gibson
2022-05-18 23:28 ` [PATCH 3/3] tests: Don't check exit code for every command in demo mode Stefano Brivio
2022-05-19 3:49 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoW+NBuHrB5dx/QB@yekko \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).