public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: Re: [PATCH] qrap.1: Clarify it takes a qemu command, not a path
Date: Thu, 19 May 2022 14:14:41 +1000	[thread overview]
Message-ID: <YoXEMeo99fPONfXa@yekko> (raw)
In-Reply-To: <20220517123558.1892286-1-sbrivio@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1488 bytes --]

On Tue, May 17, 2022 at 02:35:58PM +0200, Stefano Brivio wrote:
> Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>

Reviewed-by: David Gibson <david(a)gibson.dropbear.id.au>

> ---
>  qrap.1 | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/qrap.1 b/qrap.1
> index 8b1f863..cc73f1e 100644
> --- a/qrap.1
> +++ b/qrap.1
> @@ -19,10 +19,10 @@ A running instance of \fBpasst\fR(1) is probed checking for UNIX domain sockets,
>  answering a dummy ARP request, with names starting from
>  \fI/tmp/passt_1.socket\fR up to \fI/tmp/passt_64.socket\fR.
>  
> -If first and second arguments are not a socket number and a path, that is,
> +If first and second arguments are not a socket number and a command, that is,
>  respectively, \fIFDNUM\fR and \fIQEMU_CMD\fR, \fBqrap\fR will try to locate a
> -qemu binary and patch the command line to specify a network device and a
> -\fInetdev\fR back-end for usage with \fBpasst\fR(1).
> +qemu executable in \fBPATH\fR and patch the command line to specify a network
> +device and a \fInetdev\fR back-end for usage with \fBpasst\fR(1).
>  
>  If \fBqrap\fR patches the command line, it will remove any potentially
>  conflicting network device, that is, any \fI-netdev\fR or \fI-net\fR option, or

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2022-05-19  4:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-17 12:35 [PATCH] qrap.1: Clarify it takes a qemu command, not a path Stefano Brivio
2022-05-19  4:14 ` David Gibson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YoXEMeo99fPONfXa@yekko \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).