[PATCH] qrap.1: Clarify it takes a qemu command, not a path

[PATCH] qrap.1: Clarify it takes a qemu command, not a path

[Stefano Brivio]

[-- Attachment #1: Type: text/plain, Size: 1133 bytes --]

Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>
---
 qrap.1 | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/qrap.1 b/qrap.1
index 8b1f863..cc73f1e 100644
--- a/qrap.1
+++ b/qrap.1
@@ -19,10 +19,10 @@ A running instance of \fBpasst\fR(1) is probed checking for UNIX domain sockets,
 answering a dummy ARP request, with names starting from
 \fI/tmp/passt_1.socket\fR up to \fI/tmp/passt_64.socket\fR.
 
-If first and second arguments are not a socket number and a path, that is,
+If first and second arguments are not a socket number and a command, that is,
 respectively, \fIFDNUM\fR and \fIQEMU_CMD\fR, \fBqrap\fR will try to locate a
-qemu binary and patch the command line to specify a network device and a
-\fInetdev\fR back-end for usage with \fBpasst\fR(1).
+qemu executable in \fBPATH\fR and patch the command line to specify a network
+device and a \fInetdev\fR back-end for usage with \fBpasst\fR(1).
 
 If \fBqrap\fR patches the command line, it will remove any potentially
 conflicting network device, that is, any \fI-netdev\fR or \fI-net\fR option, or
-- 
@@ -19,10 +19,10 @@ A running instance of \fBpasst\fR(1) is probed checking for UNIX domain sockets,
 answering a dummy ARP request, with names starting from
 \fI/tmp/passt_1.socket\fR up to \fI/tmp/passt_64.socket\fR.
 
-If first and second arguments are not a socket number and a path, that is,
+If first and second arguments are not a socket number and a command, that is,
 respectively, \fIFDNUM\fR and \fIQEMU_CMD\fR, \fBqrap\fR will try to locate a
-qemu binary and patch the command line to specify a network device and a
-\fInetdev\fR back-end for usage with \fBpasst\fR(1).
+qemu executable in \fBPATH\fR and patch the command line to specify a network
+device and a \fInetdev\fR back-end for usage with \fBpasst\fR(1).
 
 If \fBqrap\fR patches the command line, it will remove any potentially
 conflicting network device, that is, any \fI-netdev\fR or \fI-net\fR option, or
-- 
2.35.1

Re: [PATCH] qrap.1: Clarify it takes a qemu command, not a path

[David Gibson]

[-- Attachment #1: Type: text/plain, Size: 1488 bytes --]

On Tue, May 17, 2022 at 02:35:58PM +0200, Stefano Brivio wrote:
> Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>

Reviewed-by: David Gibson <david(a)gibson.dropbear.id.au>

> ---
>  qrap.1 | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/qrap.1 b/qrap.1
> index 8b1f863..cc73f1e 100644
> --- a/qrap.1
> +++ b/qrap.1
> @@ -19,10 +19,10 @@ A running instance of \fBpasst\fR(1) is probed checking for UNIX domain sockets,
>  answering a dummy ARP request, with names starting from
>  \fI/tmp/passt_1.socket\fR up to \fI/tmp/passt_64.socket\fR.
>  
> -If first and second arguments are not a socket number and a path, that is,
> +If first and second arguments are not a socket number and a command, that is,
>  respectively, \fIFDNUM\fR and \fIQEMU_CMD\fR, \fBqrap\fR will try to locate a
> -qemu binary and patch the command line to specify a network device and a
> -\fInetdev\fR back-end for usage with \fBpasst\fR(1).
> +qemu executable in \fBPATH\fR and patch the command line to specify a network
> +device and a \fInetdev\fR back-end for usage with \fBpasst\fR(1).
>  
>  If \fBqrap\fR patches the command line, it will remove any potentially
>  conflicting network device, that is, any \fI-netdev\fR or \fI-net\fR option, or

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]