From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: Re: [PATCH] qrap.1: Clarify it takes a qemu command, not a path
Date: Thu, 19 May 2022 14:14:41 +1000
Message-ID: <YoXEMeo99fPONfXa@yekko>
In-Reply-To: <20220517123558.1892286-1-sbrivio@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1267208659976815029=="

--===============1267208659976815029==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Tue, May 17, 2022 at 02:35:58PM +0200, Stefano Brivio wrote:
> Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>

Reviewed-by: David Gibson <david(a)gibson.dropbear.id.au>

> ---
>  qrap.1 | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/qrap.1 b/qrap.1
> index 8b1f863..cc73f1e 100644
> --- a/qrap.1
> +++ b/qrap.1
> @@ -19,10 +19,10 @@ A running instance of \fBpasst\fR(1) is probed checking=
 for UNIX domain sockets,
>  answering a dummy ARP request, with names starting from
>  \fI/tmp/passt_1.socket\fR up to \fI/tmp/passt_64.socket\fR.
> =20
> -If first and second arguments are not a socket number and a path, that is,
> +If first and second arguments are not a socket number and a command, that =
is,
>  respectively, \fIFDNUM\fR and \fIQEMU_CMD\fR, \fBqrap\fR will try to locat=
e a
> -qemu binary and patch the command line to specify a network device and a
> -\fInetdev\fR back-end for usage with \fBpasst\fR(1).
> +qemu executable in \fBPATH\fR and patch the command line to specify a netw=
ork
> +device and a \fInetdev\fR back-end for usage with \fBpasst\fR(1).
> =20
>  If \fBqrap\fR patches the command line, it will remove any potentially
>  conflicting network device, that is, any \fI-netdev\fR or \fI-net\fR optio=
n, or

--=20
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--===============1267208659976815029==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ0FBZEZpRUVvVUx4V3U0L1dz
MGRCK1h0Z3lwWTRnRXdZU0lGQW1LRnhDc0FDZ2tRZ3lwWTRnRXcKWVNJRWJnLy9TcmFvQXJCeWQz
ZXZkcHdlWElacHQ3RjQwcXNTRng3cHNnazkvL3N5bUV1a1BlNlZnS1Q0OTdjeAprVFViczVvWEN5
U0YzM2thVUU1T09yeFNiVGxDa3RrYkFvNFdPY3JLMVpKRHRhcGtkbnV6Q29tVnBrSkpFcThlCndH
Q0pVOFNKMnYwYTlna01ScnNQYW9JbS94cWVVcHhkUEg5b21LK1A0UzlZNERhZFA4WjdDS2toZFZu
NUM1ZTIKdVBKRTJTYzVERDNZVytvbFJ5d3pvM014VFNTS0tHVXVCM09Tc01Td0Y0TmZYazRjRjJT
cWNuWFVJUyt4MHI3dwpTeDlEUUNTcUduYnVjWFBqbnQ4NFhJTUlCTXczNmZoalhob2NVeUJYUTY0
SW93RUphSHVDOW0wOE9jWXJaTnBhCm1CdGsxRGFPR1d0V2UwcUg4ODBuYzZqTWtaTFJBWFRrcmoy
WFhOK0JUN29XVGlTQlZsV0FKNWdXVlE1OFRRYVAKMnM3SFI5Q1FRVmgyWnBpMVk3djJHNGRRaXpj
U2VjWnV4Z3NweFV6QjBLUXV2Q2JMeTB2dCtDaURRTEJjK251VQpJaTA4bTdFMTB1cVlNaEtVUEg4
aVhjV01vZ3NRZHZSYnBkNVMwdU1KR2RQK1RyQ1lta0hIbkNuWlA3d2dxdTFuCjllQUxPUTMyOGc5
Z1RycW83UGhSMmdRRFdkNFp1MlJSOGJWMTVrU09UZGx0UGs2Z1hpa2JHeWd6UUI0ZkZJY0gKS242
OWkxRy82ZVRsRUtlVGtPS2lpSHZDdk12eEc4MFY0V0FkclE1VXJ5bi8rRWtyOGpHNWN0ODVtZWpU
SEpPVwpZZGE0ZSt5d1hhazFzR3pTLzc4TndZZDFLbW00d3FKaWpQcTFaM1ByNkN2cHZ4d1FIZTQ9
Cj14aUQwCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo=

--===============1267208659976815029==--