public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: Re: [PATCH 4/5] Use dhclient instead of udhcpc
Date: Tue, 14 Jun 2022 12:47:18 +1000	[thread overview]
Message-ID: <Yqf2tk1/SvLIQfCK@yekko> (raw)
In-Reply-To: <20220614033259.1d9eda12@elisabeth>

[-- Attachment #1: Type: text/plain, Size: 1152 bytes --]

On Tue, Jun 14, 2022 at 03:32:59AM +0200, Stefano Brivio wrote:
> On Fri, 10 Jun 2022 12:32:44 +1000
> David Gibson <david(a)gibson.dropbear.id.au> wrote:
> 
> > For some reason, the passt/pasta tests and examples use dhclient for
> > DHCPv6, but in most cases use udhcpc for DHCPv4.
> 
> ...the reason was that udhcpc doesn't do DHCPv6, and for DHCP I
> started with udhcpc,

Yeah, that's kinda what I guessed.

> then wanted to add a bit of diversity (udhcpc in
> tests for pasta, dhclient for passt) -- it helped to find some bugs
> earlier on.

Ah.  So I think we could potentially restore that kind of testing, but
move it into tests with specifically constructed guests (or container
images) where we can choose the distro and get udhcpc (or other
clients to test those to. For now, I don't think we want it in the
"base" set of tests though.

> Given that dhclient is anyway pickier than udhcpc, I think we can
> safely stick to the former at this point.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2022-06-14  2:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-10  2:32 [PATCH 0/5] More test fixes for Fedora host David Gibson
2022-06-10  2:32 ` [PATCH 1/5] tests: Use more explicit netcat options for distro/fedora tests David Gibson
2022-06-14 14:10   ` Stefano Brivio
2022-06-15  0:35     ` David Gibson
2022-06-10  2:32 ` [PATCH 2/5] Don't abbreviate ip(8) arguments in examples and tests David Gibson
2022-06-10  2:32 ` [PATCH 3/5] Tweak dhclient arguments for readability David Gibson
2022-06-10  2:32 ` [PATCH 4/5] Use dhclient instead of udhcpc David Gibson
2022-06-14  1:32   ` Stefano Brivio
2022-06-14  2:47     ` David Gibson [this message]
2022-06-10  2:32 ` [PATCH 5/5] tests: Use nmap-ncat instead of openbsd netcat for pasta tests David Gibson
2022-06-18  7:03   ` Stefano Brivio
2022-06-14  1:32 ` [PATCH 0/5] More test fixes for Fedora host Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yqf2tk1/SvLIQfCK@yekko \
    --to=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).