From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson To: passt-dev@passt.top Subject: Re: [PATCH 1/5] tests: Use more explicit netcat options for distro/fedora tests Date: Wed, 15 Jun 2022 10:35:24 +1000 Message-ID: In-Reply-To: <20220614161048.251abe01@elisabeth> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7638069328591319800==" --===============7638069328591319800== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Tue, Jun 14, 2022 at 04:10:48PM +0200, Stefano Brivio wrote: > On Fri, 10 Jun 2022 12:32:41 +1000 > David Gibson wrote: >=20 > > distro/fedora contains two versions of the basic tests, used for different > > Fedora versions. One uses explicit listening address for netcat in some > > extra places, the other does not. Apparently the older netcat versions > > didn't require the explicit addresses. Not supplying addresses doesn't > > test anything useful though, just a detail in netcat's behaviour. So, > > it's cleaner to just always supply explicit addresses. > >=20 > > In addition, we're explicitly expecting the nmap version of ncat, also > > known as "ncat". So, it's more explicit what we're after if we invoke it > > via that name rather than "nc", which will go via an /etc/alternatives > > link. > >=20 > > Signed-off-by: David Gibson > > --- > > test/distro/fedora | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > >=20 > > diff --git a/test/distro/fedora b/test/distro/fedora > > index f2f8f27..b7f1e3b 100644 > > --- a/test/distro/fedora > > +++ b/test/distro/fedora > > @@ -16,13 +16,13 @@ htools wget virt-edit guestfish head sed cat kill > > =20 > > # Quick pasta test: send message from init to ns, and from ns to init > > def distro_quick_pasta_test > > -host (nc -6 -l -p 10000 > /tmp/init_msg; echo "from_init" | nc ::1 9999)= & > > +host (ncat -6 -l -p 10000 ::1 > /tmp/init_msg; echo "from_init" | ncat := :1 9999) & >=20 > This doesn't work: >=20 > $ ncat -6 -l -p 9999 ::1 > /tmp/ns_msg & > [1] 21 > $ Ncat: bind to ::1:31337: Address already in use. QUITTING. >=20 > because with ncat(1) '-p' doesn't specify the listening port -- I see that > you changed this to the right version for tests under 'pasta/', that works > fine. I fixed this up (together with the other occurrences), re-running > tests now, I can merge the fix-up directly. Ah, thanks. I noticed that wrinkle while I was working on this, but obviously I missed fixing up at least one of the instances, sorry. I guess it's kind of inevitable given that I don't have the full testsuite running yet :/. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --===============7638069328591319800== Content-Type: application/pgp-signature Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" MIME-Version: 1.0 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ0FBZEZpRUVvVUx4V3U0L1dz MGRCK1h0Z3lwWTRnRXdZU0lGQW1LcEtTNEFDZ2tRZ3lwWTRnRXcKWVNLQVp3Ly9aUWlyUFpyWVFM dXFwTDh2bXpoUDZtT01YNjBqVldQdFEzT0N5ckwzdnVicUY0cm5sOFN2NWs4RApZTnNuTjR4Kytx WCtiT1dlUDR1bTRhN1pyQnc4ellId0FTRjdqR24wK0hDTmw0S2NrZktKbHZYV1d4cGVhS2pOCkpz UEZuY3dDOUFidlR3clFhVHdjOUpta1VmMnBQSkRYYzIxOXNjTFQ2ZWpnUm1tekU2amJ6c25lY0Nj RHdIZFIKY3YzU09BclRFKzhNWXFTM09yeHFsNmgrWmxqT1h5WDUwQWtUSXhRUWJheEszWTh0T1BM VEFESFJFQ0Vsc3cvKwpkbjROeXN0cFhCN3hOZ1JlOGUrZlNjd0orSTE0VmlCTDk1enNSdWtGZXZ0 b2hNMmRiVE12R1RxclVrUkV6Uk15CmRMQnN0MEpqZDVMK29KdGpyZmVYRzFVVER6ZWJaMjYwc3ZY Rk8vcnV1UTd6S2dER2pkTWlvRkU3OXBMMlUzbmYKQW5QaHR0MDNvaVlzOHI5dmJ6S05iMlAxZzZy aTlvQXhPbUsxT09YZ2hSakFvOWhDNU42ekVVQzdnWlJWeks1NQo4TngvekYrMUhtaVNOZndTM3F3 alBKU3RDNEdzU2g2S3p0QmJrb0hyb003M3BZaEd3Uk50cFRwU3VDelZvZnZzCktpcnVzWGZ5dStI TEhKVzVEYjlDdERQOVlkM3cvYmROd2hpUG9wbDlTa0NhWEFCOVQxUHBiSWlKS2RmUWRucXIKSXIx TXBSSE9rdFRIZXFTSmswem1UbndGNjBFMmxLZUh6K3kyUVNRNVpxOElyem1iRVliOHRVb21TVTZO NWYwUAp5T3Z5V0Q4R2k0UUgwUGdDZGVKQ2FUTVVpVjFQTnA3c1B4OFhyVTJDMXhiTUFmc3JrS1E9 Cj04b0U3Ci0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo= --===============7638069328591319800==--