From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: Re: [PATCH 6/6] Makefile: Spell prefix as PREFIX
Date: Wed, 15 Jun 2022 10:42:23 +1000
Message-ID: <Yqkq7xbF9KDE6WaQ@yekko>
In-Reply-To: <20220614164505.5775bca0@elisabeth>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4058919262247207917=="

--===============4058919262247207917==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

On Tue, Jun 14, 2022 at 04:45:05PM +0200, Stefano Brivio wrote:
> On Tue, 14 Jun 2022 15:12:26 +1000
> David Gibson <david(a)gibson.dropbear.id.au> wrote:
> 
> > Makefile conventions (at least in the GNUish world) tend to control the
> > base install directory with the variable $(PREFIX) (all caps).  The passt
> > Makefile has the same thing but in lower case $(prefix).  Capitalize it to
> > match conventions.
> 
> I've been wondering about this when I first added it to the Makefile,
> and I couldn't really find a rationale for it. From the documentation
> of GNU make:
> 
> 	http://www.gnu.org/software/make/manual/make.html#Directory-Variables
> 	http://www.gnu.org/software/make/manual/make.html#DESTDIR
> 
> prefix is (conventionally) lowercase, DESTDIR is uppercase, so I'd
> stick to that. I guess there's just some historic reason behind it. Some
> Makefiles of long-standing projects use prefix, some PREFIX.

Huh.. interesting.  I guess the things I've looked at personally must
have tended towards PREFIX.  I'd assumed the GNU conventions specified
that, but apparently not.

Ok, let's drop this one.

> By the way, the rest of the series all look good to me (and is very
> appreciated!).

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--===============4058919262247207917==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ0FBZEZpRUVvVUx4V3U0L1dz
MGRCK1h0Z3lwWTRnRXdZU0lGQW1LcEt1Z0FDZ2tRZ3lwWTRnRXcKWVNKd1F3LytOUWdBcXZ5dEVF
eHVYZVMxNzd1MmIvMjJZSnNZSk1wS1piMVFEU0Y4YU1VeHYyenAvMU1xd1lLSwo1Y1NpdU9jcEhX
V2JNNzhIN1JCYkIrcDJhYy9MWllYUW5PRHFkcFFyTjBZZityZGdXT1VGNTFTbTJDYWhiTVJKClNM
OEI0SEZ2QVR3Y3ViVldHaitpZHZRVG1aemlJdHFYcTNaNlQxdFBERTlJTURqWENxTmNXY0pGdFB4
UVJkS0EKM0NsbkhUeUgzN3FqU0lObjN0NGNzRHJZN2UrUDQwTkNmTlVSOVg4cllITUJGdi9jUHZQ
K3hoMmxRRWNYaEp6RwpuYkkyb3Q3OEpOSkVXK2phZ05sMjl2LzBxVWR5d1NtajMrNHFETmJnLzNP
MjVwaXJQV1lZOHNIMEhqMmRJa3ROCjRQS2l3Q1ExMkp1MlpXRkdZWkFHWWI1dlMybE9rRXduVm9F
M0VVZFlnc0hTREFGa1QvS2liMG9TMjE5SHNzQ20KSHUycitneDBjbFE4NUY0b0NrUU5yVk80M1ZV
aU53bEVUNlpoUnhnL1NMNmdoQjZRWFhuNlZNWHVxTitydTBsZwppejMxSGk1bjZPQTh0TitSTlJB
b1VCL3BZVGdZYU1IRElJTnJodlJNbTVxK1M0ai9yQlZkRTByUEdBWEVnbFV0Ck82aTZtb1JMNVV1
NmNqdDd1UjF0eGUwdC9aUmM1eXd3MlNTMHhGNWpHMGdHZjhyVVE4SDRLMWFVTjAzZk1WMkIKaGcx
R1RWR2txSitZVGk4N2tIT1VNdHZORVozRWRXK1c3M0dtaVNHRUk0ZHdVdythTVpWdUJIYWRxeW9Q
ZnFGUApMZDFMeFVBU0ZjeWF0bmFyUGxwdk4zenZDV3dJcDZFUkl4RnorN2FYRWhRdnJwbXlnTnc9
Cj0rb2o4Ci0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo=

--===============4058919262247207917==--