From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson To: passt-dev@passt.top Subject: Re: [PATCH 00/15] Test fixes, batch 4 Date: Wed, 13 Jul 2022 20:19:35 +1000 Message-ID: In-Reply-To: <20220713080414.2dd19657@elisabeth> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8666933186404427114==" --===============8666933186404427114== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Wed, Jul 13, 2022 at 08:04:14AM +0200, Stefano Brivio wrote: > On Wed, 13 Jul 2022 12:11:24 +1000 > David Gibson wrote: >=20 > > On Tue, Jul 12, 2022 at 02:13:07PM +0200, Stefano Brivio wrote: > > > On Tue, 12 Jul 2022 18:26:37 +1000 > > > David Gibson wrote: > > > =20 > > > > On Mon, Jul 11, 2022 at 11:42:09AM +0200, Stefano Brivio wrote: =20 > > > > > On Thu, 7 Jul 2022 16:53:11 +0200 > > > > > Stefano Brivio wrote: > > > > > =20 > > > > > > [...] > > > > > > > > > > > > I'm running the tests now, let's see. :) =20 > > > > >=20 > > > > > For some reason qemu refuses to boot the OpenSUSE Leap 15.1 image m= ade > > > > > this way, I haven't really looked into that yet. =20 > > > >=20 > > > > Huh. I ran into a bunch of problems with the OpenSUSE Leap images > > > > when I tried to do the image preparation stuff for them. But when I > > > > rolled that back and just did the image download separate, it seemed > > > > to work for me. Well... that is, it boots up and executes commands > > > > okay. =20 > > >=20 > > > Ah, wait a moment, did you perhaps forget to commit the > > > distro/opensuse part for patch 14/15? The changes for distro/debian and > > > distro/fedora in that patch look complete, distro/ubuntu has changes > > > just for two versions, and distro/opensuse is not changed by that patch > > > at all. =20 > >=20 > > No. I fiddled around with handling the SuSE and older Ubuntu images, > > got bogged down in details and decided to postpone that until a later > > time. So I'm deliberately only handling the images which can be > > handled by the common script I added there for now. > >=20 > > > It took me a bit to figure out because the prepared images actually > > > work, but the test doesn't use them -- it's trying to use a temporary > > > file that doesn't exist anymore. =20 > >=20 > > Um, what prepared images? AFAICT my Makefile only generates prepared > > images for Debian, Fedora and the newer Ubuntu cases. For SuSE and > > the older Ubuntu the test scripts now have qemu-img commands creating > > temporary images from the pre-downlaoded images (added in patch 13/15). >=20 > Oops, right, I missed that, I was confused by the fact that the image > didn't exist. >=20 > I guess DOWNLOAD_ASSETS (from patch 13/15) in test/Makefile should also > include OPENSUSE_IMGS, that's all. Added, re-running the whole thing > now. Ah, dammit, you're right. In fact OPENSUSE_IMGS is in the list in 13/15, then it's incorrectly removed in 14/15. IIRC, I took it off the download list, because I got some weird results which I thought meant that just the download patch was breaking the opensuse tests. Eventually realized I was misinterpreting the results, but forgot to put it back in the list. Didn't catch it because the downloads were so slow I never removed the images to try the build from scratch. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --===============8666933186404427114== Content-Type: application/pgp-signature Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" MIME-Version: 1.0 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ0FBZEZpRUVvVUx4V3U0L1dz MGRCK1h0Z3lwWTRnRXdZU0lGQW1MT25Da0FDZ2tRZ3lwWTRnRXcKWVNLYnRRLzhEdHVJR1NqZW5t UDVkaGVBVjg1dm5jRXdIZnBjQlJtZmVqMUE1Wm0zT2hscXNhNTBvMW01R3BHOApOY0F5a21sakJj QlkwalFsdkpidjVMeHhCa2hWK3llU05JTG5aVkxxT2hkbEJaWUVwRHp1YWJaVDlXdmdyREVPClBS eHFKTUg0eEcxbFVqTjBDQ01GWjF0Q1hBcTF3eWwrNnVyTGJMMFM0aW4raVZTOUxGcTVJcURZSUg3 VXpPY0EKMFgvTjZMbGtkMGc3K0FjZmo1aDJqM3dsOVpXWmVYZmhsTUZtczBYS09Kdi9JL3lpcThB UWtMOWdQd2lVemJnKwpFUXNDZGVuZ1FnVUhQNm5PUm5ZMjl3TU1JdVV6WVM2ZDQ0b2FXNTZBejFX ZHZSS2dNci9BMTk1TXd1WURMNUM1ClRqaWVJMndlbFZVOUw4VXhQamxWWFM4Qkt3bDhGUGZ5NGZK UWJjRDJUNWdnSHZxVnlDUGRnWnY1NGpzUDRlVDYKMmJmVExoaFVsc1FmSmxZTGF0LzNldzdzZStV cDlUYUpZaElycFZORUdpL0hsY3VBOUpicXdBTTlyTGNEVktEOQpCbVlGRWl3MVI5MHJVM3JIeC9T YlQzcG1VTk1RVG5zS25TeEs1ZHowTGpuRnlYRkhRVjROTWYxVmpBZTRvT1doCndxTlBZQkVtOVJp R1NRTDNuSSt0ZUZWZjk4Z3ZkeVJTSEM0TmtyU1NER0ZQQnIrVzFqR0FabDU1WUxpRTNLYlgKNFNZ VGpWSzRrSC9vc09LOUhLemt5eWRkOGY5QUNjMkhnN0pnWXFndzg2YnF5c2NSc3gxcXN2bndqdEJk dkxBVwp5UVYvSEpzMGtMaWZsWFhQT0RBQ2tlejNwOXBLU0dSOEs0MmU4UnB6VXUxSTV5NVV6YzQ9 Cj1pcU42Ci0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo= --===============8666933186404427114==--