From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: Re: [PATCH] passt: Truncate PID file on open()
Date: Sat, 23 Jul 2022 12:27:25 +1000
Message-ID: <YttcjZrOOWx7gh29@yekko>
In-Reply-To: <20220722174232.438316-1-sbrivio@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2992001116007272131=="

--===============2992001116007272131==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

On Fri, Jul 22, 2022 at 07:42:32PM +0200, Stefano Brivio wrote:
> Otherwise, if the current PID has fewer digits than a previously
> written one, the content will be wrong.
> 
> Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>

Reviewed-by: David Gibson <david(a)gibson.dropbear.id.au>

> ---
>  passt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/passt.c b/passt.c
> index a8d94b4..01eed1b 100644
> --- a/passt.c
> +++ b/passt.c
> @@ -390,7 +390,7 @@ int main(int argc, char **argv)
>  
>  	if (*c.pid_file) {
>  		if ((pidfile_fd = open(c.pid_file,
> -				       O_CREAT | O_WRONLY | O_CLOEXEC,
> +				       O_CREAT | O_TRUNC | O_WRONLY | O_CLOEXEC,
>  				       S_IRUSR | S_IWUSR)) < 0) {
>  			perror("PID file open");
>  			exit(EXIT_FAILURE);

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--===============2992001116007272131==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ0FBZEZpRUVvVUx4V3U0L1dz
MGRCK1h0Z3lwWTRnRXdZU0lGQW1MYlhIb0FDZ2tRZ3lwWTRnRXcKWVNMY0RBLy9TbFZPdjVPeHkx
UHNPRWRISUFuYTh0MTRwNGIwdjkxbjlkNktyVlRwVXVpSFp2RXJzRzZEcDJzZApBSUFDc01zWnhZ
Y1R5cHk5QUVWYVlvQjArYzIyeFo2ajQxZVE0NVNBWjd4Znp3VHBISEdla0dFT2IrU1BveFpqClpt
K0hZK2VhZDBkYWVCWTNHZys3Ymw5VG05UDZBRzl5WkZCZ2xvRkc0T1JnbDB6ajVwdjFHQmdmblhU
NUNSYTgKeHl3dXRrUllQcFFSczhxZGlHMStTeGRuLzVtR3orNTh4dytiQ1orRC9PejhSUzl6SUlC
OXQ2cUd1aDFBR2pHQwp5a2hNU0t1Q2ZMZ1dSY1J3akxGb1dWaDBPSlZYOWtzVjFkaXNMYmJYWkFF
OFRnb0lzYjJ6dWFSZXFUSEp1dXRpCkM5cENwTDZZSU9PVk9vNjd0dXhEdGE2U2w1TDhaWTB5SERO
WUsyREd3eXk3VVZVOTRjdE9MbTBkV2JiUDBHcGUKN0lxZGloMDk2T3Y1bHE3YVRNUWJqYWlxZ0pm
TklCcWw5L3lRM1o2TkZxbENXZ2Y2a2lmN0RiSE1IeWlxZVZyQQpraW5QMHVYVVIvQ2ZCVHZOa0dx
SDFkcnp6WHVvaThHWFA4RXRpOGE3QUgyRi9QVHhJTU1Yb0RLN2N2TkZmZUM1CkZhYXNEYy9tWkRz
Nmlka2dQWkJoYXc3TkFIb2VQNFlKdGwvYVI2WEZwUk9sRVBCZjFoWjFaUThlWE5uZzUvS0kKQU9R
Q01scWtLVjRFZlRYTkJuN2hya2ExNDJxN3BRYldrQ29TNXJNU0hzRktGOXJrTGFwbkxLdUVCVjBF
Ky90aAp0NTMvdlNtakt0MVlUaWVETitURVJlMEx3cmhzbFhpd2FkT2xkazFOTi85OGMxcDQwZEE9
Cj05bDF2Ci0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo=

--===============2992001116007272131==--