From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject:
 Re: [PATCH 7/8] Use explicit --netns option rather than multiplexing with PID
Date: Tue, 30 Aug 2022 11:12:50 +1000
Message-ID: <Yw1kElWXsuowYwfH@yekko>
In-Reply-To: <20220829211650.1a89a7d4@elisabeth>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4483207120982210410=="

--===============4483207120982210410==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Aug 29, 2022 at 09:16:50PM +0200, Stefano Brivio wrote:
> On Fri, 26 Aug 2022 14:58:38 +1000
> David Gibson <david(a)gibson.dropbear.id.au> wrote:
>=20
> > [...]
> >
> > +++ b/passt.1
> > @@ -15,7 +15,10 @@
> >  [\fIOPTION\fR]...
> >  .br
> >  .B pasta
> > -[\fIOPTION\fR]... [\fIPID\fR|\fIPATH\fR|\fINAME\fR]
> > +[\fIOPTION\fR]... [\fIPID\fR]
> > +.br
> > +.B pasta
> > +[\fIOPTION\fR]... \fB--netns\fR [\fIPATH\fR|\fINAME\fR]
> > =20
> >  .SH DESCRIPTION
> > =20
> > @@ -59,7 +62,7 @@ or with the \fBqrap\fR(1) wrapper.
> >  equivalent functionality to network namespaces, as the one offered by
> >  \fBpasst\fR for virtual machines.
> > =20
> > -If PID, PATH or NAME are given, \fBpasta\fR associates to an existing us=
er and
> > +If PID or --netns are given, \fBpasta\fR associates to an existing user =
and
> >  network namespace. Otherwise, \fBpasta\fR creates a new user and network
> >  namespace, and spawns an interactive shell within this context. A \fItap=
\fR
> >  device within the network namespace is created to provide network connec=
tivity.
> > @@ -445,7 +448,14 @@ Default is \fBauto\fR.
> >  Target user namespace to join, as a path. If PID is given, without this =
option,
> >  the user namespace will be the one of the corresponding process.
> > =20
> > -This option requires PID, PATH or NAME to be specified.
> > +This option requires --netns or a PID to be specified.
> > +
> > +.TP
> > +.BR \-\-netns " " \fIspec
> > +Target network namespace to join, as a path or a name.  A name is treate=
d as
> > +with \fBip-netns(8)\fR as a equivalent to a path in \fI/run/netns\fR.
>=20
> an equivalent (I can fix this up on merge).

Oops, sorry.  I think I meant to say just "as equivalent", which I
think reads better than "as an equivalent".

--=20
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--===============4483207120982210410==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ0FBZEZpRUVvVUx4V3U0L1dz
MGRCK1h0Z3lwWTRnRXdZU0lGQW1NTlpBb0FDZ2tRZ3lwWTRnRXcKWVNMYm13Ly9RdXNpUXZqYzFW
bTl4bUZWOE12RC9PTkVtK3hXZFdLTnJIaTRicmJKQjRzcjlSZFU2M09pSHlvNQpFbTJMN1owZlB0
ZjRUZGpTdW1CRk5YTE9aNE9NOEtzL1Q3UEN0b243Z0IzSGpOb3Q3QXYzZXkvR1RlbE9ZVXl2ClZH
clBveDlPK3I2UVIrQ3VDWWJPZVU0cXQ0ZHBCZjNZQmppeUdlQzlxWC9iSGsxL2tBK0FyNTJXQ1R6
UnZlUEkKMUtFQTU2a3JVdWZ0SmQ5ZkRhN09EQ0UvdFhtaGZMb0JiTG1KQURuVjJXMDhtTWJJZGhh
ZkxMSUJEVHMvU0pGQQpMbUxURjNMcUZzSWE1Y25UZy9JQzEzVjV2ek9Iekc3TC9MVnVWRHN2N0hO
dXYzVFJ0NmZzUGtPVFFZS1lsYlBBCjQxY3ZUWm9rNy9vdUxhdzNvUXpldmNYWVAvVE1sTysvRmVC
bHZnbDMwRnBYL01mVmRqTmFTWkI5THdaODNhU2QKUHdyNG01cFBVTjRRSFQ1dFFjb0pOdjFsMHU5
S1JOTTNGb2toSHpTa09aV3BNckxqS3hDTkV3TnpPV0RreDJMUgp4b3NiK0Z5NmIwYmNuaTY5T2px
aDNyWVhHai9MVkYweUFraFBxbDlLTU1EUHZ2UEttV0srMytzUEtQR2VhWlQvClNmNWlrV0w3NVR5
SXNxMFM2MkZtNk8zQlF2NmNpdnFPcVZ6RTdYUVFSMmhBaXZJR25VSXRuRGJ1NXdERm9Jem0KUVpv
YitpRTFDMWExWG92VkorYWVVRVhYWTg2a2dZVi8yVmdBRGl4SjJNZFNxL3hrY01UbFZzZ0pEU0Mv
SnVzawpaZDluVHd0V2dHTE9PYmN3TzRsb0JKSmlQZnZOMzFaWXVrNEZGazZjTURLRVNNTmNKZFU9
Cj13UmJxCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo=

--===============4483207120982210410==--