From: "Daniel P. Berrangé" <berrange@redhat.com>
To: passt-dev@passt.top
Subject: Re: [PATCH 1/2] fedora: Add %dir entries for own SELinux policy directory and documentation
Date: Fri, 02 Sep 2022 16:42:41 +0100 [thread overview]
Message-ID: <YxIkcTUqJ3YAZBQ5@redhat.com> (raw)
In-Reply-To: <20220902153842.2757216-2-sbrivio@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1932 bytes --]
On Fri, Sep 02, 2022 at 05:38:41PM +0200, Stefano Brivio wrote:
> fedora-review says:
>
> Note: No known owner of /usr/share/selinux/packages/passt,
> /usr/share/doc/passt
>
> Reported-by: Daniel P. Berrangé <berrange(a)redhat.com>
> Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>
> ---
> contrib/fedora/passt.spec | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/contrib/fedora/passt.spec b/contrib/fedora/passt.spec
> index 922f584..1e328e2 100644
> --- a/contrib/fedora/passt.spec
> +++ b/contrib/fedora/passt.spec
> @@ -49,7 +49,7 @@ This package adds SELinux enforcement to passt(1) and pasta(1).
> %make_build
>
> %install
> -%make_install DESTDIR=%{buildroot} prefix=%{_prefix} bindir=%{_bindir} mandir=%{_mandir} docdir=%{_docdir}/passt
> +%make_install DESTDIR=%{buildroot} prefix=%{_prefix} bindir=%{_bindir} mandir=%{_mandir} docdir=%{_docdir}/%{name}
> %ifarch x86_64
> ln -sr %{buildroot}%{_mandir}/man1/passt.1 %{buildroot}%{_mandir}/man1/passt.avx2.1
> ln -sr %{buildroot}%{_mandir}/man1/pasta.1 %{buildroot}%{_mandir}/man1/pasta.avx2.1
> @@ -70,6 +70,8 @@ semodule -r passt 2>/dev/null || :
> semodule -r pasta 2>/dev/null || :
>
> %files
> +%dir %{_datadir}/selinux/packages/%{name}
This needs to be in the -selinux package %files list
> +%dir %{_docdir}/%{name}
If you're going to use %{name} here...
> %license LICENSES/{AGPL-3.0-or-later.txt,BSD-3-Clause.txt}
I'd suggest keeping this as the first item in %files
> %doc %{_docdir}/passt/README.md
> %doc %{_docdir}/passt/demo.sh
..then be consistent here too
> --
> 2.35.1
>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2022-09-02 15:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 15:38 [PATCH 0/2] Two further fixes for Fedora's spec file issues Stefano Brivio
2022-09-02 15:38 ` [PATCH 1/2] fedora: Add %dir entries for own SELinux policy directory and documentation Stefano Brivio
2022-09-02 15:42 ` Daniel P. Berrangé [this message]
2022-09-02 15:58 ` Stefano Brivio
2022-09-02 15:38 ` [PATCH 2/2] fedora: Add selinux-policy Requires: tag Stefano Brivio
2022-09-02 15:43 ` Daniel P. Berrangé
2022-09-02 15:47 ` Stefano Brivio
2022-09-02 15:51 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxIkcTUqJ3YAZBQ5@redhat.com \
--to=berrange@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).