From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel P. =?utf-8?q?Berrang=C3=A9?= <berrange@redhat.com>
To: passt-dev@passt.top
Subject: Re: [PATCH 1/2] fedora: Add %dir entries for own SELinux policy
 directory and documentation
Date: Fri, 02 Sep 2022 16:42:41 +0100
Message-ID: <YxIkcTUqJ3YAZBQ5@redhat.com>
In-Reply-To: <20220902153842.2757216-2-sbrivio@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4316464090668452843=="

--===============4316464090668452843==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Sep 02, 2022 at 05:38:41PM +0200, Stefano Brivio wrote:
> fedora-review says:
>=20
>   Note: No known owner of /usr/share/selinux/packages/passt,
>   /usr/share/doc/passt
>=20
> Reported-by: Daniel P. Berrang=C3=A9 <berrange(a)redhat.com>
> Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>
> ---
>  contrib/fedora/passt.spec | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/contrib/fedora/passt.spec b/contrib/fedora/passt.spec
> index 922f584..1e328e2 100644
> --- a/contrib/fedora/passt.spec
> +++ b/contrib/fedora/passt.spec
> @@ -49,7 +49,7 @@ This package adds SELinux enforcement to passt(1) and pas=
ta(1).
>  %make_build
> =20
>  %install
> -%make_install DESTDIR=3D%{buildroot} prefix=3D%{_prefix} bindir=3D%{_bindi=
r} mandir=3D%{_mandir} docdir=3D%{_docdir}/passt
> +%make_install DESTDIR=3D%{buildroot} prefix=3D%{_prefix} bindir=3D%{_bindi=
r} mandir=3D%{_mandir} docdir=3D%{_docdir}/%{name}
>  %ifarch x86_64
>  ln -sr %{buildroot}%{_mandir}/man1/passt.1 %{buildroot}%{_mandir}/man1/pas=
st.avx2.1
>  ln -sr %{buildroot}%{_mandir}/man1/pasta.1 %{buildroot}%{_mandir}/man1/pas=
ta.avx2.1
> @@ -70,6 +70,8 @@ semodule -r passt 2>/dev/null || :
>  semodule -r pasta 2>/dev/null || :
> =20
>  %files
> +%dir %{_datadir}/selinux/packages/%{name}

This needs to be in the -selinux package %files list

> +%dir %{_docdir}/%{name}

If you're going to use %{name} here...

>  %license LICENSES/{AGPL-3.0-or-later.txt,BSD-3-Clause.txt}

I'd suggest keeping this as the first item in %files

>  %doc %{_docdir}/passt/README.md
>  %doc %{_docdir}/passt/demo.sh

..then be consistent here too

> --=20
> 2.35.1
>=20

With regards,
Daniel
--=20
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


--===============4316464090668452843==--