From: "Daniel P. Berrangé" <berrange@redhat.com>
To: passt-dev@passt.top
Subject: Re: [PATCH 2/2] fedora: Add selinux-policy Requires: tag
Date: Fri, 02 Sep 2022 16:43:39 +0100 [thread overview]
Message-ID: <YxIkq3MXOzEAHC/J@redhat.com> (raw)
In-Reply-To: <20220902153842.2757216-3-sbrivio@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1424 bytes --]
On Fri, Sep 02, 2022 at 05:38:42PM +0200, Stefano Brivio wrote:
> fedora-review says:
>
> Note: Directories without known owners:
> /usr/share/selinux/packages/passt, /usr/share/doc/passt,
> /usr/share/selinux, /usr/share/selinux/packages
>
> and selinux-policy owns those two last ones.
>
> Reported-by: Daniel P. Berrangé <berrange(a)redhat.com>
> Signed-off-by: Stefano Brivio <sbrivio(a)redhat.com>
> ---
> contrib/fedora/passt.spec | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/fedora/passt.spec b/contrib/fedora/passt.spec
> index 1e328e2..f9fd0ab 100644
> --- a/contrib/fedora/passt.spec
> +++ b/contrib/fedora/passt.spec
> @@ -34,7 +34,7 @@ requiring any capabilities or privileges.
> %package selinux
> BuildArch: noarch
> Summary: SELinux support for passt and pasta
> -Requires: %{name} = %{version}-%{release}
> +Requires: selinux-policy, %{name} = %{version}-%{release}
It isn't a requirement, but my preference would be separate Requires
line for each dep, as it makes the spec more readable.
> Requires(post): policycoreutils, %{name}
> Requires(preun): policycoreutils, %{name}
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2022-09-02 15:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 15:38 [PATCH 0/2] Two further fixes for Fedora's spec file issues Stefano Brivio
2022-09-02 15:38 ` [PATCH 1/2] fedora: Add %dir entries for own SELinux policy directory and documentation Stefano Brivio
2022-09-02 15:42 ` Daniel P. Berrangé
2022-09-02 15:58 ` Stefano Brivio
2022-09-02 15:38 ` [PATCH 2/2] fedora: Add selinux-policy Requires: tag Stefano Brivio
2022-09-02 15:43 ` Daniel P. Berrangé [this message]
2022-09-02 15:47 ` Stefano Brivio
2022-09-02 15:51 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxIkq3MXOzEAHC/J@redhat.com \
--to=berrange@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).