From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: Re: [PATCH v2 3/4] test: Parameterize run time for throughput
 performance tests
Date: Wed, 07 Sep 2022 10:40:06 +1000
Message-ID: <YxfoZv80BfeicKQX@yekko>
In-Reply-To: <20220906182242.603a5080@elisabeth>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1101226252365330175=="

--===============1101226252365330175==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

On Tue, Sep 06, 2022 at 06:22:42PM +0200, Stefano Brivio wrote:
> On Fri,  2 Sep 2022 12:04:33 +1000
> David Gibson <david(a)gibson.dropbear.id.au> wrote:
> 
> > Currently all the throughput tests are run for 30s.  This is reflected in
> > both the actual parameters given to the iperf commands, but also in the
> > matching sleeps in test_iperf3.
> > 
> > Allow this to be adjusted more easily with a new parameter to test_iperf3.
> > 
> > Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au>
> > ---
> >  test/lib/test       |  9 +++++----
> >  test/perf/passt_tcp | 44 +++++++++++++++++++++++---------------------
> >  test/perf/passt_udp | 43 ++++++++++++++++++++++---------------------
> >  test/perf/pasta_tcp | 42 ++++++++++++++++++++++--------------------
> >  test/perf/pasta_udp | 43 ++++++++++++++++++++++---------------------
> >  5 files changed, 94 insertions(+), 87 deletions(-)
> > 
> > diff --git a/test/lib/test b/test/lib/test
> > index 600399b..8eb1ee5 100755
> > --- a/test/lib/test
> > +++ b/test/lib/test
> > @@ -28,6 +28,7 @@ test_iperf3() {
> >  	__dest="${1}"; shift
> >  	__port="${1}"; shift
> >  	__procs="$((${1} - 1))"; shift
> > +	__time="${1}"; shift
> 
> I'm adding, on merge, this line:
> 
> # $7:	Run time, in seconds
> 
> to the comment above.

Oops, thanks.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--===============1101226252365330175==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ0FBZEZpRUVvVUx4V3U0L1dz
MGRCK1h0Z3lwWTRnRXdZU0lGQW1NWDZGOEFDZ2tRZ3lwWTRnRXcKWVNMWmh3LzlISEJlOThJZDFF
bWQ4S21FWlo2M2lHZ2lsb251ZEJpaEtVZDhxdXdoa0ZNY3hBL0NwRkZiRG45RQpLQ1JEeWIwYXdO
Q3BhOWwwY0lGakdtTHdqYVB2Smk4S1E5MjNmS1RjRXlmTXZnaDg5QXVpVloxS1VoZUJrOVo3CkM0
V2xYRXdFTWY1ajdSWSthdFYyb0dYMlFBOXN2Q2tsODVvWFNyMFg0bDJZL2VNb281aDhCdUpuaFNQ
V29zdU4KUld3TFJXNmF0SVR3SmxDMXhSMWRYdEpZVHhCamhoY25TWnZtRm1RYnh0MkE2UXo4eXBs
Zm5TNk4zSjI2WktmNgorc3NpdXhiazBQUVRDdmhSTzdEZGUvck9ZWGtWYjMzYW95cU15SUFVTDdh
a05qdTNRelRIRXhtMVpnc3Y5OWt1CjhKbTBvSEY4RnZPREt1eitBY1ZvUHZodHhMV3JoRDJ2TTBZ
a2RMQy9ldkV5M2lwWTRDK2YydkJXRzQxNzJqMUoKZVBHUW1kQ241bXZyNTRCYUlEU2NWbk5adnVv
Mk5zb1pVdWFJYjY5SENQNVoxZjBMSS9MR0FucXpTRVpEZGRaeApMRTVwWENXZXE3S2J4Q3RkbWtO
SzZPdzd1d0E4Zi93dEljVnFGUVlTUnJNMjNRNHpoelJwbklQM3dCelZKTUs5Cm45bzNDRGRZWExk
b1hxWEhJZVB1NllNOHgxMDRLOEtRMThGdHQ3L0pBR2t6NExGQW9WckVuTnBGWVpXRDV4Y3gKNGtC
TGNFbS9hMDJCMURzNmFtZXR3MDVOVXZJZ0cxS1Y2RWI3b1VUdkhJVk5IRVcvSUNPdU5zNituUVBn
Sjd6egp6eDhnYXh2NGo1Zk5TTnpKRU5Sa1BiSkxaK1VEaG56K1plQnFycW5HQmFqOTQ4OGo0dm89
Cj0xSWx2Ci0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo=

--===============1101226252365330175==--