From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: Re: [PATCH v2 08/10] Correctly handle --netns-only in pasta_start_ns()
Date: Sat, 10 Sep 2022 17:25:36 +1000 [thread overview]
Message-ID: <Yxw78NpwNC/8seVI@yekko> (raw)
In-Reply-To: <20220909163420.32970c5b@elisabeth>
[-- Attachment #1: Type: text/plain, Size: 1765 bytes --]
On Fri, Sep 09, 2022 at 04:34:20PM +0200, Stefano Brivio wrote:
> On Thu, 8 Sep 2022 13:59:05 +1000
> David Gibson <david(a)gibson.dropbear.id.au> wrote:
>
> > --netns-only is supposed to make pasta use only a network namespace, not
> > a user namespace. However, pasta_start_ns() has this backwards, and if
> > --netns-only is specified it creates a user namespace but *not* a network
> > namespace. Correct this.
> >
> > Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au>
> > ---
> > pasta.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/pasta.c b/pasta.c
> > index 0fd45e4..7eac8e9 100644
> > --- a/pasta.c
> > +++ b/pasta.c
> > @@ -244,8 +244,8 @@ void pasta_start_ns(struct ctx *c, int argc, char *argv[])
> >
> > pasta_child_pid = clone(pasta_setup_ns,
> > ns_fn_stack + sizeof(ns_fn_stack) / 2,
> > - (c->netns_only ? 0 : CLONE_NEWNET) |
> > - CLONE_NEWIPC | CLONE_NEWPID | CLONE_NEWUSER |
> > + (c->netns_only ? 0 : CLONE_NEWUSER) |
> > + CLONE_NEWIPC | CLONE_NEWPID | CLONE_NEWNET |
>
> Oh, funny, so it never worked in this case.
>
> I thought anyway your plan was to drop --netns-only altogether, and if
> a --netns option is specified without --userns, then it's implied. Is
> that still on the table (outside the scope of this series I presume)?
Well.. having reduced the lifetome of netns_only to within conf()
alone, I felt a lot less urgency about removing it entirely. It might
still be nicer to remove it anyway; I'll have another look.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-09-10 7:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 3:58 [PATCH v2 00/10] Clean up handling of userns David Gibson
2022-09-08 3:58 ` [PATCH v2 01/10] Don't store UID & GID persistently in the context structure David Gibson
2022-09-08 3:58 ` [PATCH v2 02/10] Split checking for root from dropping root privilege David Gibson
2022-09-09 14:33 ` Stefano Brivio
2022-09-10 7:09 ` David Gibson
2022-09-08 3:59 ` [PATCH v2 03/10] Consolidate determination of UID/GID to run as David Gibson
2022-09-09 14:33 ` Stefano Brivio
2022-09-10 7:15 ` David Gibson
2022-09-10 20:43 ` Stefano Brivio
2022-09-12 9:53 ` David Gibson
2022-09-13 3:49 ` Stefano Brivio
2022-09-13 5:20 ` David Gibson
2022-09-08 3:59 ` [PATCH v2 04/10] Safer handling if we can't open /proc/self/uid_map David Gibson
2022-09-09 14:33 ` Stefano Brivio
2022-09-10 7:23 ` David Gibson
2022-09-08 3:59 ` [PATCH v2 05/10] Move self-isolation code into a separate file David Gibson
2022-09-09 14:33 ` Stefano Brivio
2022-09-10 7:23 ` David Gibson
2022-09-10 20:43 ` Stefano Brivio
2022-09-08 3:59 ` [PATCH v2 06/10] Consolidate validation of pasta namespace options David Gibson
2022-09-08 3:59 ` [PATCH v2 07/10] Clean up and rename conf_ns_open() David Gibson
2022-09-08 3:59 ` [PATCH v2 08/10] Correctly handle --netns-only in pasta_start_ns() David Gibson
2022-09-09 14:34 ` Stefano Brivio
2022-09-10 7:25 ` David Gibson [this message]
2022-09-11 8:26 ` David Gibson
2022-09-13 3:50 ` Stefano Brivio
2022-09-08 3:59 ` [PATCH v2 09/10] Handle userns isolation and dropping root at the same time David Gibson
2022-09-08 3:59 ` [PATCH v2 10/10] Allow --userns when pasta spawns a command David Gibson
2022-09-09 14:34 ` Stefano Brivio
2022-09-10 7:29 ` David Gibson
2022-09-10 20:42 ` Stefano Brivio
2022-09-09 14:36 ` [PATCH v2 00/10] Clean up handling of userns Stefano Brivio
2022-09-10 7:30 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yxw78NpwNC/8seVI@yekko \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).