From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: Re: [PATCH v2 05/10] Move self-isolation code into a separate file
Date: Sat, 10 Sep 2022 17:23:56 +1000
Message-ID: <Yxw7jJ6Z7oTnviEL@yekko>
In-Reply-To: <20220909163358.64600147@elisabeth>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2403948041513289883=="

--===============2403948041513289883==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Sep 09, 2022 at 04:33:58PM +0200, Stefano Brivio wrote:
> On Thu,  8 Sep 2022 13:59:02 +1000
> David Gibson <david(a)gibson.dropbear.id.au> wrote:
>=20
> > [...]
> >
> > +++ b/isolation.c
> >
> > [...]
> >
> > +/**
> > + * sandbox() - Unshare IPC, mount, PID, UTS, and user namespaces, "unmou=
nt" root
> > + *
> > + * Return: negative error code on failure, zero on success
> > + */
> > +int sandbox(struct ctx *c)
>=20
> Same here, I would "document" "c".

Not in scope for this patch, since it's a pure code motion.

--=20
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--===============2403948041513289883==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ0FBZEZpRUVvVUx4V3U0L1dz
MGRCK1h0Z3lwWTRnRXdZU0lGQW1NY080WUFDZ2tRZ3lwWTRnRXcKWVNJb1NRLy9ZdWdEMXZ3ZkFZ
ZjYzTDZzdjhTTWVvelk5SHJ1ZUY3QVE2S3YwaHRZdXFVRVpzTzdpTjVraUxDZQo5RzAyOUV3RzRO
c1I0c0p2SGVIMWRLZ09XVGRxRWN2dnJSTENZemlSMis5R2hMUk1LRnczVkN1andFYk9iRjZSCjV4
ZzR4MG1jNC9GREJYM0duQ1NlenB5OWpJTGRaOXdjTXFPa1FWM0ZMSXdUY293ZWFVK1BLTUJzRWZJ
R3JKdHcKblhOZkZ1czJWMXlYZG1Mc29jdDRZSzNvMVQzWlRkZnVQSE1nay9vY2xiUlRtTDFlSUE4
REpLcmRabWE1RVY1SwpEdzRMYmhuRVMwaSt6d0VLSUE2SmFsbkNOY3ZOdDJNNndNejZoNCt5UXEy
WkovYk5nK3oxMzRVd1VLQ2ZzQnB1ClMreS93WHhxL3g2b29GSUhoVVNhdldzSjFlbDBQQkVzc2F3
NVRURU9rSjdqTFBDbG1PVVd0cDdlNUdtVkVIK2IKL09maVVweGdFc20zeS9rVlAyUjBoTzlLUDAr
QXNObFBzZ2ZaUDBsNEVUaW1OQ3dxeDd0U1d6WjlCVnlHU2pmNgpmRkV1dlE3QzRFRXdpSFgvWndM
a010UlZQUUJWcUEvNlBtTXRBTTVEOFJpbStQci8vNTJ2TVRQMmNwZ3VEZHB1CnY1a1hBd0JzeE5F
d0dhakhPYWlQK25hOXU5MHhEb2VuNW83TjlBT2lIVVhkN3h3SjFDbHg2aC9qNFRWRjloTTUKTGJw
ZEtEK0ZxUWV6bUljdnNGZlNLeStXT1FJZXdCbWJDcHlOaUdubm5mUUNUWWxOYjdzemFhVzl5ZmJl
WGNYWgo2Tk16eDhWeXBtdFY3NEpjWk93ZWkwSk1MOUorMk1SejNwOTE4UXJSeGg3UHU2Qkh3Vlk9
Cj12YmV2Ci0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo=

--===============2403948041513289883==--