On Fri, Sep 09, 2022 at 04:36:21PM +0200, Stefano Brivio wrote: > On Thu, 8 Sep 2022 13:58:57 +1000 > David Gibson wrote: > > > Sorry for the resend, but I found a bug that means this will fail to > > build on some distros / versions. > > > > Our handling of user namespaces is more complex than it needs to be. > > This simplifies the handling by identifying and entering (or creating) > > the correct userns earlier, so that later code doesn't need to deal > > with it any more. > > > > Along the way we make a number of other cleanups to handling of userns > > and setting our user and group. > > > > This is based on my earlier test command dispatch and performance test > > cleanup series. > > > > Changes since v1: > > * Fixed overenthusiastic pruning of #includes when moving the > > self-isolation code which broke compile on some distro versions > > I haven't tested this yet, but it looks great. > > I can fix up those small things I reported directly while merging, if > you agree, and apply. > > A suggestion on how to update the man page as a result of 10/10 would > help, though. I'll respin next week with that adjusted amongst other nits. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson