From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Gibson To: passt-dev@passt.top Subject: Re: [PATCH v2 00/10] Clean up handling of userns Date: Sat, 10 Sep 2022 17:30:23 +1000 Message-ID: In-Reply-To: <20220909163621.6807f8d5@elisabeth> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8415339381386161024==" --===============8415339381386161024== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit On Fri, Sep 09, 2022 at 04:36:21PM +0200, Stefano Brivio wrote: > On Thu, 8 Sep 2022 13:58:57 +1000 > David Gibson wrote: > > > Sorry for the resend, but I found a bug that means this will fail to > > build on some distros / versions. > > > > Our handling of user namespaces is more complex than it needs to be. > > This simplifies the handling by identifying and entering (or creating) > > the correct userns earlier, so that later code doesn't need to deal > > with it any more. > > > > Along the way we make a number of other cleanups to handling of userns > > and setting our user and group. > > > > This is based on my earlier test command dispatch and performance test > > cleanup series. > > > > Changes since v1: > > * Fixed overenthusiastic pruning of #includes when moving the > > self-isolation code which broke compile on some distro versions > > I haven't tested this yet, but it looks great. > > I can fix up those small things I reported directly while merging, if > you agree, and apply. > > A suggestion on how to update the man page as a result of 10/10 would > help, though. I'll respin next week with that adjusted amongst other nits. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --===============8415339381386161024== Content-Type: application/pgp-signature Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" MIME-Version: 1.0 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ0FBZEZpRUVvVUx4V3U0L1dz MGRCK1h0Z3lwWTRnRXdZU0lGQW1NY1BRZ0FDZ2tRZ3lwWTRnRXcKWVNMU29oQUFwL1gwdld3ZGt4 SjYrblgzL2xITTZQRmphMll5S29iRmlLNTRsVXhnT3gxdlZoK3grbk1RT2xSKwp5em9vT1NOQVFO akx6dEVnaDlkUlNpZTlpSVdTZ0tYNzNJMTlFZkFuemJUV3RhdGNUUHUvYnlhTkVrR1VUWmdDCkU1 NUM4YTJTNWx4NXV4UjNFaVVUc0d4Y01abGJXOWJHOFhQbHRXQ2pjRGYxSWdHajhGbUo5TW1meFkz cXRWNWwKQVJBcjFXT2JlS1ZyYVB3NzB6Y2tZV0hiUHVLdGNpRWpuenR1b0NuQXU3VEdpaHZaMXhm MVFXS0ZzRDZXcFE2MgozQVlHd09zNittSjlaZ0JjTWgxdWFQVVFmRnc4cFFvRlAwNmZvV1hBSmg3 Z0RvaWc1R0JCRVdmUXNMZ09ZMXJVCi9aN0NiZ0YzRnpxOXd4WXBMLzM0YzFyL05vc1VuajVMVWF3 aVd4QmNBSkE5aGhlaEV4SmxaOW42NVJtdEYxbmEKTkc0Ym5MdFBHM29ieXY2SEtCVEtVNGY4Zlhh ZUZHdjkvOXdtczZhL0g3enNYdzlNZU14SzNpZHREbERMUkNBegovVWwrR2YyWm5VMXl4Z2h1ZFVN TWFBQ0pSYmxaSEtTUmZlMU5FbjNBd3BwOUthTC9RZ09LQjlOR3VqNEx2bjBnCnRhc2VQU1psM21W RjJPUnhzemRQWURFdDhYT08yZGUwSWY4TzlzWFRJYm9EdW5ScXFweVU3d3pJSVB3RnZWM3UKK0o3 WDZQb1JRbUN5NlpkRGNQenpESHFhUmgrMFdrTW9qVTg4TnNic3FYUzZ3T090OHh2bCtxYk1XSEtk UTFZbgoxNEVTY1RBNFJnMUJPNHEzNGVMQ1RpajhsbXZ0ZGJtMTBaQWFTN1VHYnZBaEU0Rk13cUE9 Cj02d2JRCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo= --===============8415339381386161024==--