From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject:
 Re: [PATCH v2 11/11] test: Use new-style command issue for passt_in_ns tests
Date: Sat, 10 Sep 2022 16:47:28 +1000
Message-ID: <YxwzACF5jF4y8jTF@yekko>
In-Reply-To: <20220909171902.0d2f3efe@elisabeth>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1482083003411397105=="

--===============1482083003411397105==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Sep 09, 2022 at 05:19:02PM +0200, Stefano Brivio wrote:
> On Thu,  8 Sep 2022 11:49:20 +1000
> David Gibson <david(a)gibson.dropbear.id.au> wrote:
>=20
> > Put the pieces together to use the new style context based dispatch for
> > the passt_in_pasta tests.
> >=20
> > Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au>
> >
> > [...]
> >
> > +++ b/test/lib/setup
> >
> > [...]
> >
> > @@ -156,21 +147,18 @@ setup_passt_in_ns() {
> >  	[ ${TRACE} -eq 1 ] && __opts=3D"${__opts} --trace"
> > =20
> >  	if [ ${VALGRIND} -eq 1 ]; then
> > -		pane_run PASST "make clean"
> > -		pane_status PASST
> > -		pane_run PASST "make valgrind"
> > -		pane_status PASST
> > -		pane_run PASST "valgrind --max-stackframe=3D$((4 * 1024 * 1024)) --tra=
ce-children=3Dyes --vgdb=3Dno --error-exitcode=3D1 --suppressions=3Dtest/valg=
rind.supp ./passt -f ${__opts} -t 10001,10011,10021,10031 -u 10001,10011,1002=
1,10031 -P passt.pid"
> > +		context_run passt "make clean"
> > +		context_run passt "make valgrind"
> > +		context_run_bg passt "valgrind --max-stackframe=3D$((4 * 1024 * 1024))=
 --trace-children=3Dyes --vgdb=3Dno --error-exitcode=3D1 --suppressions=3Dtes=
t/valgrind.supp ./passt -f ${__opts} -t 10001,10011,10021,10031 -u 10001,1001=
1,10021,10031 -P passt.pid"
> >  	else
> > -		pane_run PASST "make clean"
> > -		pane_status PASST
> > -		pane_run PASST "make"
> > -		pane_status PASST
> > -		pane_run PASST "./passt -f ${__opts} -t 10001,10011,10021,10031 -u 100=
01,10011,10021,10031 -P passt.pid"
> > +		context_run passt "make clean"
> > +		context_run passt "make"
> > +		context_run_bg passt "./passt -f ${__opts} -t 10001,10011,10021,10031 =
-u 10001,10011,10021,10031 -P passt.pid"
> >  	fi
> >  	sleep 5
> > =20
> > -	pane_run GUEST './qrap 5 qemu-system-$(uname -m)'                  \
> > +	GUEST_CID=3D94557
>=20
> While this seems to be perfectly valid: is it supposed to be random, or
> a specific number for a reason I'm missing...?

It's entirely arbitrary - I went with as close a visual approximation
of 'passt' as I could manage with digits (which isn't very close at
all).

--=20
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

--===============1482083003411397105==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlRSXpCQUVCQ0FBZEZpRUVvVUx4V3U0L1dz
MGRCK1h0Z3lwWTRnRXdZU0lGQW1NY012a0FDZ2tRZ3lwWTRnRXcKWVNMcWdnLytQeHI2LzZZakZI
djJkT3pDL2I3U2xpeDdaM0xKb21YSklSdjljSk5OaTN3TUlTZ0taK1NCWndWLwpPNERCVlFNYWhQ
TDdmVFNHY2VlRDlodEFSUEs5c24valBSRHNDRlFkbHYrMXdDVkJmOUk5eldOTlZrdXNZOStpCkVQ
MlJIY21YVnJLQm9Xbm5vSHZLbVpPQlVEQ3BjNTY4THZJWm00SGhLS1luZ3BRa2czVW05SWJJc3Ev
MVkrNXQKYWRlS2pHMVdmUmhiYkIycnV4NnNWWStsR2E0eTVkNE1Ja0JpeXNTc1ZoQkN1UEJ2RXNy
VmUxZTcyaytYRzc3TAp4MkZsMlUvSWFFZzVuMG1aL0Y0a2I1QVMzZFRweWpBZ2tES1RsaFl0dUc3
S3lhNzFMOGNUV3N4eFlIMDhnTzVzCmVCSmJWZTJxR3lhWXZCYTZyeVZOQ1YxeEUyeXdweiswY1dw
MWVCUGkxWW5Zc2lYQnRVV3NaUmEvOUMybFFVYkwKNmZLM0FpWXc4ZVl6b3pieWZSR0VZait5aitW
NE0vNXNxeG9RZWJMV3MzZUxZaElKaXB5a08vcVZKWGFRdUY0NQpuR2xMNXJmRXJnUjJjd2thbTcz
ZjgzYzJCNFRveWhiVkJNU0Z1c1BrRkhVY3ExMmR2WlNDRTliWmY1dW0rQ2RQClEyLzl4OEJ0L1Fm
ckcwTVFGUm5iN1FlWUxpUndFNjQxdE5rNEwwYTlOdDBYVFNHRnFYa09IOTBPZUlXcEVQNDEKT0o3
b0lEcVIxNzI5MUYvMndNc3hTOUJpL09LaVV0cmRVZ21Kem5QV2VWOTB3K3Y4eTlma0dXc0FxZFFi
cWhIZwpGZG1UWGRMKzRkc2Z0bDJrWEpidDd5N1VRTUk5OWpkd1NpaUY5d3I1clhCTTRnZ2NITDA9
Cj1XamxKCi0tLS0tRU5EIFBHUCBTSUdOQVRVUkUtLS0tLQo=

--===============1482083003411397105==--