From: David Gibson <david@gibson.dropbear.id.au>
To: passt-dev@passt.top
Subject: Re: [PATCH 08/12] clang-tidy: Disable 'readability-identifier-length'
Date: Sat, 24 Sep 2022 13:06:35 +1000 [thread overview]
Message-ID: <Yy50Oz54on11tWOM@yekko> (raw)
In-Reply-To: <20220924010855.45e930d6@elisabeth>
[-- Attachment #1: Type: text/plain, Size: 1823 bytes --]
On Sat, Sep 24, 2022 at 01:08:55AM +0200, Stefano Brivio wrote:
> On Fri, 23 Sep 2022 17:20:34 +1000
> David Gibson <david(a)gibson.dropbear.id.au> wrote:
>
> > This check complains about any identifier of less than 3 characters. For
> > locals and parameters this is often pointlessly verbose. Disable it.
> >
> > Signed-off-by: David Gibson <david(a)gibson.dropbear.id.au>
> > ---
> > Makefile | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/Makefile b/Makefile
> > index 432ee7a..0598865 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -237,6 +237,10 @@ docs: README.md
> > #
> > # - concurrency-mt-unsafe
> > # TODO: check again if multithreading is implemented
> > +#
> > +# - readability-identifier-length
> > +# Complains about any identifier <3 characters, reasonable for
> > +# globals, pointlessly verbose for locals and parameters.
> >
> > clang-tidy: $(SRCS) $(HEADERS)
> > clang-tidy -checks=*,-modernize-*,\
> > @@ -260,7 +264,7 @@ clang-tidy: $(SRCS) $(HEADERS)
> > -bugprone-easily-swappable-parameters,\
> > -readability-function-cognitive-complexity,\
> > -altera-struct-pack-align,\
> > - -concurrency-mt-unsafe \
> > + -concurrency-mt-unsafe,-readability-identifier-length \
>
> I would rather keep those (unrelated) switches on different lines, I
> find it's a bit easier to follow through the comments like that.
>
> I can change this on merge if you agree, unless you respin.
I am respinning, so I've made this change.
> I reviewed the rest of the series, it looks great to me, I have no
> further observations -- but I haven't tested it yet.
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-09-24 3:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 7:20 [PATCH 00/12] Assorted test fixes, batch 7 David Gibson
2022-09-23 7:20 ` [PATCH 01/12] test: Add wait_for() shell helper David Gibson
2022-09-23 23:07 ` Stefano Brivio
2022-09-24 2:59 ` David Gibson
2022-09-23 7:20 ` [PATCH 02/12] test: Remove unnecessary sleeps from layout functions David Gibson
2022-09-23 23:08 ` Stefano Brivio
2022-09-24 3:02 ` David Gibson
2022-09-23 7:20 ` [PATCH 03/12] test: Remove unnecessary sleeps from shutdown tests David Gibson
2022-09-23 7:20 ` [PATCH 04/12] test: More robust wait for pasta/passt to be ready David Gibson
2022-09-23 23:08 ` Stefano Brivio
2022-09-24 3:03 ` David Gibson
2022-09-23 7:20 ` [PATCH 05/12] test: Use --config-net for namespace setup David Gibson
2022-09-23 7:20 ` [PATCH 06/12] test: Simplify data handling for transfer tests David Gibson
2022-09-23 23:08 ` Stefano Brivio
2022-09-23 7:20 ` [PATCH 07/12] test: Remove unneccessary pane naming from layout_two_guests David Gibson
2022-09-23 7:20 ` [PATCH 08/12] clang-tidy: Disable 'readability-identifier-length' David Gibson
2022-09-23 23:08 ` Stefano Brivio
2022-09-24 3:06 ` David Gibson [this message]
2022-09-23 7:20 ` [PATCH 09/12] cppcheck: Avoid excessive scanning due to system headers David Gibson
2022-09-23 7:20 ` [PATCH 10/12] cppcheck: Run quietly David Gibson
2022-09-23 7:20 ` [PATCH 11/12] Makefile: Simplify getting target triple for compiler David Gibson
2022-09-23 7:20 ` [PATCH 12/12] cppcheck: Add target specific headers David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yy50Oz54on11tWOM@yekko \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).